Skip to content

Commit 66c1b8b

Browse files
committed
carousel images bug fix + new placeholder service
1 parent da12b1c commit 66c1b8b

File tree

3 files changed

+64
-32
lines changed

3 files changed

+64
-32
lines changed

package-lock.json

Lines changed: 61 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/project-page/components/banner-content/BannerContent.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,10 @@ const BannerTitle = ({ title }) => (
1212

1313
const BannerImageCarousel = ({ images }) => (
1414
<div style={headerStyle}>
15-
{images[0].length > 0 ? (
15+
{images.length > 0 ? (
1616
<Carousel items={images} />
1717
) : (
18-
<img
19-
src="https://placeholdit.imgix.net/~text?txtsize=33&txt=318%C3%97180&w=318&h=180"
20-
alt="default cover"
21-
/>
18+
<img src="https://via.placeholder.com/300" alt="default cover" />
2219
)}
2320
</div>
2421
);

src/components/shared/project-card/ProjectCard.jsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ const Card = ({ width, children, onClick }) => (
1414

1515
const CardImage = ({ image }) => (
1616
<div className="project-image-container">
17-
<img
18-
src={image || 'https://placeholdit.imgix.net/~text?txtsize=33&txt=318%C3%97180&w=318&h=180'}
19-
alt="project cover"
20-
/>
17+
<img src={image || 'https://via.placeholder.com/300'} alt="project cover" />
2118
</div>
2219
);
2320

0 commit comments

Comments
 (0)