Skip to content

Commit 61a993d

Browse files
committed
Small bubble sort update.
1 parent 2a06ae2 commit 61a993d

File tree

3 files changed

+22
-7
lines changed

3 files changed

+22
-7
lines changed

Bubblesort/Bubble.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
* @version 1
1313
* @since 201712120028.
1414
* @formatter Oviedo Computing Community Extended.
15-
* @param <T> is the type to sort.
1615
*/
17-
public class Bubble<T extends Comparable<T>> {
16+
public class Bubble {
1817

1918
/**
2019
* Average: O(N^2) Worst: O(N^2) Memory: O(1)
@@ -28,7 +27,7 @@ public class Bubble<T extends Comparable<T>> {
2827
*
2928
* @param elements array to be sorted. It is sorted in the same array.
3029
*/
31-
public void sort( T[] elements ) {
30+
public static <T extends Comparable<T>> void sort( T[] elements ) {
3231
for (int i = 1; i < elements.length; i++) { // O(n)
3332
for (int j = elements.length - 1; j >= i; j--) { // O(n)
3433
if (elements[j - 1].compareTo( elements[j] ) > 0) {

Bubblesort/tests/BubbleTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,17 @@ public class BubbleTest {
1818
sortDblArr = { Double.MIN_VALUE, 0.00004, 1.9, 2.6, Double.MAX_VALUE };
1919

2020
@Test public void integerSortTest() {
21-
new Bubble<Integer>().sort( intArr );
21+
Bubble.sort( intArr );
2222
assertArrayEquals( sortIntArr, intArr );
2323
}
2424

2525
@Test public void stringSortTest() {
26-
new Bubble<String>().sort( strArr );
26+
Bubble.sort( strArr );
2727
assertArrayEquals( sortStrArr, strArr );
2828
}
2929

3030
@Test public void doubleSortTest() {
31-
new Bubble<Double>().sort( dblArr );
31+
Bubble.sort( dblArr );
3232
assertArrayEquals( sortDblArr, dblArr );
3333
}
34-
3534
}

tests/AllTests.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package tests;
2+
3+
import org.junit.runner.RunWith;
4+
import org.junit.runners.Suite;
5+
import org.junit.runners.Suite.SuiteClasses;
6+
7+
import AVLTree.tests.AllAVLTests;
8+
import BinaryHeap.tests.AllBinaryHeapTests;
9+
import Bubblesort.tests.BubbleTest;
10+
import Graph.tests.AllGraphsTests;
11+
import HashTable.tests.HashTableAllTests;
12+
13+
@RunWith(Suite.class) @SuiteClasses({ AllAVLTests.class,
14+
AllBinaryHeapTests.class, AllGraphsTests.class,
15+
HashTableAllTests.class, BubbleTest.class }) public class AllTests {
16+
17+
}

0 commit comments

Comments
 (0)