ipc: remove unnecessary inclusion of dma-trace.h#9554
Merged
kv2019i merged 1 commit intothesofproject:mainfrom Oct 10, 2024
Merged
ipc: remove unnecessary inclusion of dma-trace.h#9554kv2019i merged 1 commit intothesofproject:mainfrom
kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
dma-trace.h is only needed to implement the IPC3 sof-logger DMA trace and the definitions are not needed for IPC4 or dma-copy.c implementation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
bardliao,
dbaluta,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
marcinszkudlinski
approved these changes
Oct 9, 2024
iuliana-prodan
approved these changes
Oct 9, 2024
dbaluta
approved these changes
Oct 9, 2024
Collaborator
Author
|
@wszypelt ok to merge, this starts to be ready to go and not expecting fails on quickbuild |
|
@kv2019i Internal intel CI, all green, good to merge |
Collaborator
Author
|
sof-docs fail, windows-linux-comparison fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3ACI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dma-trace.h is only needed to implement the IPC3 sof-logger DMA trace and the definitions are not needed for IPC4 or dma-copy.c implementation.