multiband_drc: instantaneous enabled state switch on processing #9329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In present multiband_drc design, the enabled state is determined by the switch control while multiband_drc starts to process. If the switch control toggles while processing, it will take effects on the next time multiband_drc starts to process. This commit makes change to let the enabled state update instantaneously by the switch control toggle when multiband_drc is processing. Signed-off-by: Pin-chih Lin <johnylin@google.com> (cherry picked from commit 8e8ff75)
johnylin76
requested review from
lyakh,
cujomalainey,
lgirdwood,
singalsu and
ShriramShastry
cujomalainey
approved these changes
Jul 26, 2024
lgirdwood
approved these changes
Aug 5, 2024
singalsu
approved these changes
Aug 5, 2024
lyakh
reviewed
Aug 12, 2024
| @@ -328,7 +336,10 @@ static int multiband_drc_process(struct processing_module *mod, | |||
| } | |||
| } | |||
|
|
|||
| cd->multiband_drc_func(mod, source, sink, frames); | |||
| if (cd->process_enabled) | |||
There was a problem hiding this comment.
would it be possible to reassign cd->multiband_drc_func in multiband_drc_process_enable() and avoid the if here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked from stable-v2.2)
In present multiband_drc design, the enabled state is determined by the switch control while multiband_drc starts to process. If the switch control toggles while processing, it will take effects on the next time multiband_drc starts to process.
This commit makes change to let the enabled state update instantaneously by the switch control toggle when multiband_drc is processing.