boards: config: add U8 bit format support for PTL #9257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defines in PTL config files to support U8 bit format. Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
dnikodem
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Jun 25, 2024
lyakh
reviewed
Jun 26, 2024
| @@ -40,6 +40,8 @@ CONFIG_L3_HEAP=y | |||
| CONFIG_RIMAGE_SIGNING_SCHEMA="ptl" | |||
|
|
|||
| CONFIG_FORMAT_CONVERT_HIFI3=n | |||
| CONFIG_FORMAT_U8=y | |||
| CONFIG_PCM_CONVERTER_FORMAT_U8=y | |||
There was a problem hiding this comment.
curious, why don't ACE 1.5 and 2.0 support it?
There was a problem hiding this comment.
It is good question - support for U8 was tested on PTL, not sure if it is working on ACE1.5/2.0 as well (It is globally disabled in Kconfig files). From the code analysis, it appears that this format could be supported for both ACE3.0 and ACE1.5/2.0 - but the question is: do we have any requirement for support this on ACE1.5/2.0?
tmleman
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defines in PTL config files to support U8 bit format.