Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoring kcontrol values after resume #389

Closed
ranj063 opened this issue Dec 6, 2018 · 2 comments
Closed

restoring kcontrol values after resume #389

ranj063 opened this issue Dec 6, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@ranj063
Copy link
Collaborator

ranj063 commented Dec 6, 2018

Just wondering when this should be done?

Today it is done as soon as the system wakes up from runtime suspend or system suspend. runtime_suspend case is quite obvious that it needs to be right away. But is it critical to do this right after system resume? Or can this wait until after the pipeline is triggered?

We're seeing suspend/resume failures while restoring kcontrols right after resuming. I wonder if this change would help.

@ranj063 ranj063 added the enhancement New feature or request label Dec 6, 2018
@plbossart
Copy link
Member

@ranj063 sorry I didn't see this earlier. two comments

  1. the delay be implemented regardless when we enable IPCs when the pipelines is enabled (even outside of suspend/resume operations). That change depends on @mmaka1 changes for memory allocation.
  2. playing with IPC timing is like shuffling the chairs on the Titanic deck. If the IPCs aren't reliable they will fail at some point, and to some extent it's better for debug to fail hard on resume rather than fail later when pipelines are enabled.

@ranj063
Copy link
Collaborator Author

ranj063 commented Jan 11, 2019

@plbossart I think when we implement the smart suspend/smart resume feature this will be addressed automatically. So, I will close this one

@ranj063 ranj063 closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants