Skip to content

Commit d16046f

Browse files
lrgirdwobroonie
authored andcommitted
ASoC: SOF: Intel: Add Intel specific HDA firmware loader
Add support for loading DSP firmware on Intel HDA based platforms. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent a226893 commit d16046f

File tree

1 file changed

+371
-0
lines changed

1 file changed

+371
-0
lines changed

sound/soc/sof/intel/hda-loader.c

Lines changed: 371 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,371 @@
1+
// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
2+
//
3+
// This file is provided under a dual BSD/GPLv2 license. When using or
4+
// redistributing this file, you may do so under either license.
5+
//
6+
// Copyright(c) 2018 Intel Corporation. All rights reserved.
7+
//
8+
// Authors: Liam Girdwood <liam.r.girdwood@linux.intel.com>
9+
// Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
10+
// Rander Wang <rander.wang@intel.com>
11+
// Keyon Jie <yang.jie@linux.intel.com>
12+
//
13+
14+
/*
15+
* Hardware interface for HDA DSP code loader
16+
*/
17+
18+
#include <linux/firmware.h>
19+
#include <sound/hdaudio_ext.h>
20+
#include <sound/sof.h>
21+
#include "../ops.h"
22+
#include "hda.h"
23+
24+
#define HDA_FW_BOOT_ATTEMPTS 3
25+
26+
static int cl_stream_prepare(struct snd_sof_dev *sdev, unsigned int format,
27+
unsigned int size, struct snd_dma_buffer *dmab,
28+
int direction)
29+
{
30+
struct hdac_ext_stream *dsp_stream;
31+
struct hdac_stream *hstream;
32+
struct pci_dev *pci = to_pci_dev(sdev->dev);
33+
int ret;
34+
35+
if (direction != SNDRV_PCM_STREAM_PLAYBACK) {
36+
dev_err(sdev->dev, "error: code loading DMA is playback only\n");
37+
return -EINVAL;
38+
}
39+
40+
dsp_stream = hda_dsp_stream_get(sdev, direction);
41+
42+
if (!dsp_stream) {
43+
dev_err(sdev->dev, "error: no stream available\n");
44+
return -ENODEV;
45+
}
46+
hstream = &dsp_stream->hstream;
47+
48+
/* allocate DMA buffer */
49+
ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_SG, &pci->dev, size, dmab);
50+
if (ret < 0) {
51+
dev_err(sdev->dev, "error: memory alloc failed: %x\n", ret);
52+
goto error;
53+
}
54+
55+
hstream->period_bytes = 0;/* initialize period_bytes */
56+
hstream->format_val = format;
57+
hstream->bufsize = size;
58+
59+
ret = hda_dsp_stream_hw_params(sdev, dsp_stream, dmab, NULL);
60+
if (ret < 0) {
61+
dev_err(sdev->dev, "error: hdac prepare failed: %x\n", ret);
62+
goto error;
63+
}
64+
65+
hda_dsp_stream_spib_config(sdev, dsp_stream, HDA_DSP_SPIB_ENABLE, size);
66+
67+
return hstream->stream_tag;
68+
69+
error:
70+
hda_dsp_stream_put(sdev, direction, hstream->stream_tag);
71+
snd_dma_free_pages(dmab);
72+
return ret;
73+
}
74+
75+
/*
76+
* first boot sequence has some extra steps. core 0 waits for power
77+
* status on core 1, so power up core 1 also momentarily, keep it in
78+
* reset/stall and then turn it off
79+
*/
80+
static int cl_dsp_init(struct snd_sof_dev *sdev, const void *fwdata,
81+
u32 fwsize, int stream_tag)
82+
{
83+
struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata;
84+
const struct sof_intel_dsp_desc *chip = hda->desc;
85+
unsigned int status;
86+
int ret;
87+
88+
/* step 1: power up corex */
89+
ret = hda_dsp_core_power_up(sdev, chip->cores_mask);
90+
if (ret < 0) {
91+
dev_err(sdev->dev, "error: dsp core 0/1 power up failed\n");
92+
goto err;
93+
}
94+
95+
/* step 2: purge FW request */
96+
snd_sof_dsp_write(sdev, HDA_DSP_BAR, chip->ipc_req,
97+
chip->ipc_req_mask | (HDA_DSP_IPC_PURGE_FW |
98+
((stream_tag - 1) << 9)));
99+
100+
/* step 3: unset core 0 reset state & unstall/run core 0 */
101+
ret = hda_dsp_core_run(sdev, HDA_DSP_CORE_MASK(0));
102+
if (ret < 0) {
103+
dev_err(sdev->dev, "error: dsp core start failed %d\n", ret);
104+
ret = -EIO;
105+
goto err;
106+
}
107+
108+
/* step 4: wait for IPC DONE bit from ROM */
109+
ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,
110+
chip->ipc_ack, status,
111+
((status & chip->ipc_ack_mask)
112+
== chip->ipc_ack_mask),
113+
HDA_DSP_REG_POLL_INTERVAL_US,
114+
HDA_DSP_INIT_TIMEOUT_US);
115+
116+
if (ret < 0) {
117+
dev_err(sdev->dev, "error: waiting for HIPCIE done\n");
118+
goto err;
119+
}
120+
121+
/* step 5: power down corex */
122+
ret = hda_dsp_core_power_down(sdev,
123+
chip->cores_mask & ~(HDA_DSP_CORE_MASK(0)));
124+
if (ret < 0) {
125+
dev_err(sdev->dev, "error: dsp core x power down failed\n");
126+
goto err;
127+
}
128+
129+
/* step 6: enable IPC interrupts */
130+
hda_dsp_ipc_int_enable(sdev);
131+
132+
/* step 7: wait for ROM init */
133+
ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,
134+
HDA_DSP_SRAM_REG_ROM_STATUS, status,
135+
((status & HDA_DSP_ROM_STS_MASK)
136+
== HDA_DSP_ROM_INIT),
137+
HDA_DSP_REG_POLL_INTERVAL_US,
138+
chip->rom_init_timeout *
139+
USEC_PER_MSEC);
140+
if (!ret)
141+
return 0;
142+
143+
err:
144+
hda_dsp_dump(sdev, SOF_DBG_REGS | SOF_DBG_PCI | SOF_DBG_MBOX);
145+
hda_dsp_core_reset_power_down(sdev, chip->cores_mask);
146+
147+
return ret;
148+
}
149+
150+
static int cl_trigger(struct snd_sof_dev *sdev,
151+
struct hdac_ext_stream *stream, int cmd)
152+
{
153+
struct hdac_stream *hstream = &stream->hstream;
154+
int sd_offset = SOF_STREAM_SD_OFFSET(hstream);
155+
156+
/* code loader is special case that reuses stream ops */
157+
switch (cmd) {
158+
case SNDRV_PCM_TRIGGER_START:
159+
wait_event_timeout(sdev->waitq, !sdev->code_loading,
160+
HDA_DSP_CL_TRIGGER_TIMEOUT);
161+
162+
snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL,
163+
1 << hstream->index,
164+
1 << hstream->index);
165+
166+
snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,
167+
sd_offset,
168+
SOF_HDA_SD_CTL_DMA_START |
169+
SOF_HDA_CL_DMA_SD_INT_MASK,
170+
SOF_HDA_SD_CTL_DMA_START |
171+
SOF_HDA_CL_DMA_SD_INT_MASK);
172+
173+
hstream->running = true;
174+
return 0;
175+
default:
176+
return hda_dsp_stream_trigger(sdev, stream, cmd);
177+
}
178+
}
179+
180+
static struct hdac_ext_stream *get_stream_with_tag(struct snd_sof_dev *sdev,
181+
int tag)
182+
{
183+
struct hdac_bus *bus = sof_to_bus(sdev);
184+
struct hdac_stream *s;
185+
186+
/* get stream with tag */
187+
list_for_each_entry(s, &bus->stream_list, list) {
188+
if (s->direction == SNDRV_PCM_STREAM_PLAYBACK &&
189+
s->stream_tag == tag) {
190+
return stream_to_hdac_ext_stream(s);
191+
}
192+
}
193+
194+
return NULL;
195+
}
196+
197+
static int cl_cleanup(struct snd_sof_dev *sdev, struct snd_dma_buffer *dmab,
198+
struct hdac_ext_stream *stream)
199+
{
200+
struct hdac_stream *hstream = &stream->hstream;
201+
int sd_offset = SOF_STREAM_SD_OFFSET(hstream);
202+
int ret;
203+
204+
ret = hda_dsp_stream_spib_config(sdev, stream, HDA_DSP_SPIB_DISABLE, 0);
205+
206+
hda_dsp_stream_put(sdev, SNDRV_PCM_STREAM_PLAYBACK,
207+
hstream->stream_tag);
208+
hstream->running = 0;
209+
hstream->substream = NULL;
210+
211+
/* reset BDL address */
212+
snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,
213+
sd_offset + SOF_HDA_ADSP_REG_CL_SD_BDLPL, 0);
214+
snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,
215+
sd_offset + SOF_HDA_ADSP_REG_CL_SD_BDLPU, 0);
216+
217+
snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR, sd_offset, 0);
218+
snd_dma_free_pages(dmab);
219+
dmab->area = NULL;
220+
hstream->bufsize = 0;
221+
hstream->format_val = 0;
222+
223+
return ret;
224+
}
225+
226+
static int cl_copy_fw(struct snd_sof_dev *sdev, struct hdac_ext_stream *stream)
227+
{
228+
unsigned int reg;
229+
int ret, status;
230+
231+
ret = cl_trigger(sdev, stream, SNDRV_PCM_TRIGGER_START);
232+
if (ret < 0) {
233+
dev_err(sdev->dev, "error: DMA trigger start failed\n");
234+
return ret;
235+
}
236+
237+
status = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,
238+
HDA_DSP_SRAM_REG_ROM_STATUS, reg,
239+
((reg & HDA_DSP_ROM_STS_MASK)
240+
== HDA_DSP_ROM_FW_ENTERED),
241+
HDA_DSP_REG_POLL_INTERVAL_US,
242+
HDA_DSP_BASEFW_TIMEOUT_US);
243+
244+
ret = cl_trigger(sdev, stream, SNDRV_PCM_TRIGGER_STOP);
245+
if (ret < 0) {
246+
dev_err(sdev->dev, "error: DMA trigger stop failed\n");
247+
return ret;
248+
}
249+
250+
return status;
251+
}
252+
253+
int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev)
254+
{
255+
struct snd_sof_pdata *plat_data = sdev->pdata;
256+
const struct sof_dev_desc *desc = plat_data->desc;
257+
const struct sof_intel_dsp_desc *chip_info;
258+
struct hdac_ext_stream *stream;
259+
struct firmware stripped_firmware;
260+
int ret, ret1, tag, i;
261+
262+
chip_info = desc->chip_info;
263+
264+
stripped_firmware.data = plat_data->fw->data;
265+
stripped_firmware.size = plat_data->fw->size;
266+
267+
/* init for booting wait */
268+
init_waitqueue_head(&sdev->boot_wait);
269+
sdev->boot_complete = false;
270+
271+
/* prepare DMA for code loader stream */
272+
tag = cl_stream_prepare(sdev, 0x40, stripped_firmware.size,
273+
&sdev->dmab, SNDRV_PCM_STREAM_PLAYBACK);
274+
275+
if (tag < 0) {
276+
dev_err(sdev->dev, "error: dma prepare for fw loading err: %x\n",
277+
tag);
278+
return tag;
279+
}
280+
281+
/* get stream with tag */
282+
stream = get_stream_with_tag(sdev, tag);
283+
if (!stream) {
284+
dev_err(sdev->dev,
285+
"error: could not get stream with stream tag %d\n",
286+
tag);
287+
ret = -ENODEV;
288+
goto err;
289+
}
290+
291+
memcpy(sdev->dmab.area, stripped_firmware.data,
292+
stripped_firmware.size);
293+
294+
/* try ROM init a few times before giving up */
295+
for (i = 0; i < HDA_FW_BOOT_ATTEMPTS; i++) {
296+
ret = cl_dsp_init(sdev, stripped_firmware.data,
297+
stripped_firmware.size, tag);
298+
299+
/* don't retry anymore if successful */
300+
if (!ret)
301+
break;
302+
303+
dev_err(sdev->dev, "error: Error code=0x%x: FW status=0x%x\n",
304+
snd_sof_dsp_read(sdev, HDA_DSP_BAR,
305+
HDA_DSP_SRAM_REG_ROM_ERROR),
306+
snd_sof_dsp_read(sdev, HDA_DSP_BAR,
307+
HDA_DSP_SRAM_REG_ROM_STATUS));
308+
dev_err(sdev->dev, "error: iteration %d of Core En/ROM load failed: %d\n",
309+
i, ret);
310+
}
311+
312+
if (i == HDA_FW_BOOT_ATTEMPTS) {
313+
dev_err(sdev->dev, "error: dsp init failed after %d attempts with err: %d\n",
314+
i, ret);
315+
goto cleanup;
316+
}
317+
318+
/*
319+
* at this point DSP ROM has been initialized and
320+
* should be ready for code loading and firmware boot
321+
*/
322+
ret = cl_copy_fw(sdev, stream);
323+
if (!ret)
324+
dev_dbg(sdev->dev, "Firmware download successful, booting...\n");
325+
else
326+
dev_err(sdev->dev, "error: load fw failed ret: %d\n", ret);
327+
328+
cleanup:
329+
/*
330+
* Perform codeloader stream cleanup.
331+
* This should be done even if firmware loading fails.
332+
*/
333+
ret1 = cl_cleanup(sdev, &sdev->dmab, stream);
334+
if (ret1 < 0) {
335+
dev_err(sdev->dev, "error: Code loader DSP cleanup failed\n");
336+
337+
/* set return value to indicate cleanup failure */
338+
ret = ret1;
339+
}
340+
341+
/*
342+
* return master core id if both fw copy
343+
* and stream clean up are successful
344+
*/
345+
if (!ret)
346+
return chip_info->init_core_mask;
347+
348+
/* dump dsp registers and disable DSP upon error */
349+
err:
350+
hda_dsp_dump(sdev, SOF_DBG_REGS | SOF_DBG_PCI | SOF_DBG_MBOX);
351+
352+
/* disable DSP */
353+
snd_sof_dsp_update_bits(sdev, HDA_DSP_PP_BAR,
354+
SOF_HDA_REG_PP_PPCTL,
355+
SOF_HDA_PPCTL_GPROCEN, 0);
356+
return ret;
357+
}
358+
359+
/* pre fw run operations */
360+
int hda_dsp_pre_fw_run(struct snd_sof_dev *sdev)
361+
{
362+
/* disable clock gating and power gating */
363+
return hda_dsp_ctrl_clock_power_gating(sdev, false);
364+
}
365+
366+
/* post fw run operations */
367+
int hda_dsp_post_fw_run(struct snd_sof_dev *sdev)
368+
{
369+
/* re-enable clock gating and power gating */
370+
return hda_dsp_ctrl_clock_power_gating(sdev, true);
371+
}

0 commit comments

Comments
 (0)