irqchip/loongson-liointc: Fix an error handling path in liointc_init()

tititiou36 · Marc Zyngier · commit a9084d888fba · 2022-08-12T13:47:21.000+01:00
All errors lead to the error handling path, except the one dealing with "reg-names" in DT. Fix it and release some resources before returning if this test fails. Fixes: 0858ed0 ("irqchip/loongson-liointc: Add ACPI init support") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> [maz: fix commit message] Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/1a6d74ab70712279023aa7bdbd31bd3aec103bc0.1659382063.git.christophe.jaillet@wanadoo.fr
diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
@@ -207,7 +207,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision,
 					"reg-names", core_reg_names[i]);
 
 			if (index < 0)
-				return -EINVAL;
+				goto out_iounmap;
 
 			priv->core_isr[i] = of_iomap(node, index);
 		}

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision,`
`207`	`207`	`"reg-names", core_reg_names[i]);`
`208`	`208`
`209`	`209`	`if (index < 0)`
`210`		`- return -EINVAL;`
	`210`	`+ goto out_iounmap;`
`211`	`211`
`212`	`212`	`priv->core_isr[i] = of_iomap(node, index);`
`213`	`213`	`}`