Skip to content

Commit a7c6900

Browse files
committed
ASoC: SOF: remove duplicate runtime autosuspend call for sof device
Runtime PM for sof device in enabled in pcm_probe() after the topology load has completed. So autosuspend should be called after pm_runtime_enable() here. Remove the call to autosuspend() in sof_probe as this should be done after topology load has been completed. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
1 parent 0ffb067 commit a7c6900

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

sound/soc/sof/core.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,6 @@ static int sof_probe(struct platform_device *pdev)
351351
dev_dbg(sdev->dev, "created machine %s\n",
352352
dev_name(&plat_data->pdev_mach->dev));
353353

354-
/* autosuspend sof device */
355-
pm_runtime_mark_last_busy(sdev->dev);
356-
pm_runtime_put_autosuspend(sdev->dev);
357-
358354
return 0;
359355

360356
comp_err:

sound/soc/sof/pcm.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,9 @@ static int sof_pcm_probe(struct snd_soc_component *component)
712712
SND_SOF_SUSPEND_DELAY);
713713
pm_runtime_use_autosuspend(component->dev);
714714
pm_runtime_enable(component->dev);
715-
err = pm_runtime_idle(component->dev);
715+
716+
pm_runtime_mark_last_busy(component->dev);
717+
err = pm_runtime_put_autosuspend(component->dev);
716718
if (err < 0)
717719
dev_err(sdev->dev, "error: failed to enter PM idle %d\n", err);
718720

0 commit comments

Comments
 (0)