[SQUASHME] ASoC: SOF: ops: fix uninitialized use warning

plbossart · plbossart · commit 28fc73b252ea · 2018-07-03T19:05:19.000-07:00
For some architectures/compilers, 0-day reports errors

sound/soc/sof/ops.c: In function 'snd_sof_pci_update_bits_unlocked':
sound/soc/sof/ops.c:26:6: warning: 'ret' is used uninitialized in this function [-Wuninitialized]
  u32 ret;
      ^~~

Fix by forcing value to ~0 (as done in pci_read_config_dword)

Signed-off-by: Pierre-Louis Bossart &lt;pierre-louis.bossart@linux.intel.com&gt;
diff --git a/sound/soc/sof/ops.c b/sound/soc/sof/ops.c
@@ -23,7 +23,7 @@ int snd_sof_pci_update_bits_unlocked(struct snd_sof_dev *sdev, u32 offset,
 {
 	bool change;
 	unsigned int old, new;
-	u32 ret;
+	u32 ret = ~0; /* explicit init to remove uninitialized use warnings */
 
 	pci_read_config_dword(sdev->pci, offset, &ret);
 	dev_dbg(sdev->dev, "Debug PCIR: %8.8x at  %8.8x\n",

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ int snd_sof_pci_update_bits_unlocked(struct snd_sof_dev *sdev, u32 offset,`
`23`	`23`	`{`
`24`	`24`	`bool change;`
`25`	`25`	`unsigned int old, new;`
`26`		`- u32 ret;`
	`26`	`+ u32 ret = ~0; /* explicit init to remove uninitialized use warnings */`
`27`	`27`
`28`	`28`	`pci_read_config_dword(sdev->pci, offset, &ret);`
`29`	`29`	`dev_dbg(sdev->dev, "Debug PCIR: %8.8x at %8.8x\n",`