Skip to content

fix: set CREATE_NO_WINDOW creation flag on Windows #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jun 20, 2025

Addresses #196

Copy link
Contributor

github-actions bot commented Jun 20, 2025

🐰 Bencher Report

Branchset-creation-flags-on-windows
TestbedLinux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
extract📈 view plot
⚠️ NO THRESHOLD
151.90 µs
lifecycle📈 view plot
⚠️ NO THRESHOLD
733,080.00 µs
🐰 View full continuous benchmarking report in Bencher

@brianheineman brianheineman force-pushed the set-creation-flags-on-windows branch from 8f3b70c to a67b1cd Compare June 20, 2025 01:01
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (5423e5c) to head (df10999).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          75       75           
  Lines       10181    10191   +10     
=======================================
+ Hits        10023    10033   +10     
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brianheineman brianheineman force-pushed the set-creation-flags-on-windows branch from a67b1cd to df10999 Compare June 20, 2025 01:15
@brianheineman brianheineman merged commit bea018e into main Jun 20, 2025
14 checks passed
@brianheineman brianheineman deleted the set-creation-flags-on-windows branch June 20, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant