fix: set CREATE_NO_WINDOW creation flag on Windows

Author: brianheineman

Cargo.lock

@@ -29,14 +29,14 @@ anyhow = "1.0.98"
 async-trait = "0.1.88"
 axum = "0.8.4"
 criterion = "0.6.0"
-diesel = "2.2.10"
+diesel = "2.2.11"
 diesel_migrations = "2.2.0"
 flate2 = "1.1.2"
 futures-util = "0.3.31"
 hex = "0.4.3"
 indicatif = "0.17.11"
 indoc = "2.0.6"
-liblzma = "0.4.1"
+liblzma = "0.4.2"
 md-5 = "0.10.6"
 num-format = "0.4.4"
 pgvector = "0.4.1"

Cargo.toml

@@ -2,11 +2,23 @@ use crate::error::{Error, Result};
 use std::env::consts::OS;
 use std::ffi::{OsStr, OsString};
 use std::fmt::Debug;
+#[cfg(target_os = "windows")]
+use std::os::windows::process::CommandExt;
 use std::path::PathBuf;
 use std::process::ExitStatus;
 use std::time::Duration;
 use tracing::debug;
 
+/// Constant for the `CREATE_NO_WINDOW` flag on Windows to prevent the creation of a console window
+/// when executing commands. This is useful for background processes or services that do not require
+/// user interaction.
+///
+/// # References
+///
+/// - [Windows API: Process Creation Flags](https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags#flags)
+#[cfg(target_os = "windows")]
+const CREATE_NO_WINDOW: u32 = 0x0800_0000;
+
 /// Interface for `PostgreSQL` settings
 pub trait Settings {
     fn get_binary_dir(&self) -> PathBuf;
@@ -147,6 +159,11 @@ impl CommandExecutor for std::process::Command {
         let stderr: String;
         let status: ExitStatus;
 
+        #[cfg(target_os = "windows")]
+        {
+            self.creation_flags(CREATE_NO_WINDOW);
+        }
+
         if OS == "windows" && program.as_str().ends_with("pg_ctl") {
             // The pg_ctl process can hang on Windows when attempting to get stdout/stderr.
             let mut process = self
@@ -188,6 +205,11 @@ impl AsyncCommandExecutor for tokio::process::Command {
         let stderr: String;
         let status: ExitStatus;
 
+        #[cfg(target_os = "windows")]
+        {
+            self.creation_flags(CREATE_NO_WINDOW);
+        }
+
         if OS == "windows" && program.as_str().ends_with("pg_ctl") {
             // The pg_ctl process can hang on Windows when attempting to get stdout/stderr.
             let mut process = self