Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent number formatting for big numbers. #257

Open
Xoneris opened this issue Jun 17, 2024 · 2 comments
Open

Inconsistent number formatting for big numbers. #257

Xoneris opened this issue Jun 17, 2024 · 2 comments
Labels
a11y Accessibility features enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xoneris
Copy link
Contributor

Xoneris commented Jun 17, 2024

There are a few places on the site where you come across numbers bigger then 1'000 and I believe for easier readibilty it would be nice if they would be formatted. There are some places where those numbers are formatted correctly. For example the Leaderboard of a game is formatted correctly. Just seems a bit inconsistent.

I already took a peak and for some numbers it's an easy fix implementing something like Intl.NumberFormat or toLocaleString() but there are a few instances where numbrs are already being formatted, which would require further formatting.

Places where this could be applied:

  • /games
  • /gametitle
    • category sub pages
  • /races
  • /races/stats
  • /profile

There might be more.

@florence-wolfe florence-wolfe added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers a11y Accessibility features labels Jun 17, 2024
@florence-wolfe
Copy link
Collaborator

florence-wolfe commented Jun 18, 2024

Thanks for calling this out! It's been on the long TODO list of things we want to improve!!

We have an intl library that we're using to ensure consistency for SSR and CSR — https://next-intl-docs.vercel.app/docs/usage/numbers

@Xoneris
Copy link
Contributor Author

Xoneris commented Jun 18, 2024

i want to work on this issue...

I was intending on working on this, since I brought it up. But feel free to do it, I don't have a shortage of codeing project to work on haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility features enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants