[DERCBOT-1708] Google Chat Intro Message #1951
Conversation
scezen
force-pushed
the
feature/googlechat-intro-message/DERCBOT-1708
branch
from
688b1e7 to
1e40b41
Compare
scezen
force-pushed
the
feature/googlechat-intro-message/DERCBOT-1708
branch
from
449bf80 to
1e40b41
Compare
scezen
force-pushed
the
feature/googlechat-intro-message/DERCBOT-1708
branch
from
449bf80 to
27c5a7e
Compare
| private val introCooldownSeconds: Long = longProperty("tock_bot_dialog_max_validity_in_seconds", 60 * 60 * 24) | ||
|
|
||
| // Last intro send time per space + thread | ||
| private val introSentThreads: MutableMap<String, Long> = mutableMapOf() |
There was a problem hiding this comment.
High risk of memory leak here, the state stored here will not be shared across all chat-api nodes.
As discussed yesterday we need to communicate data from the ConnectorController to the Connector. Why ? Because the ConnectorController load the UserTimeline and we can rely on it as it contains a list of dialogs to have the associated Google Chat thread conversation history.
Currently we have ConnectorData to send data from the connector to the ConnectorController, when the ConnectorController needs to communicate with the Connector it uses each connector callback implementation of ConnectorCallbackBase, in our case GoogleChatConnectorCallback. Callback is used to communicated different stuff during the Action lifecycle treatment, in our case we want to tell the GoogleChatConnectorCallback connector when the UseTimeline is loaded with it so that it can extract if it's en empty / first dialog or not and the send the intro message.
Add to ConnectorCallbackBase a new method called something like initialUserTimelineLoaded, call it from the controller. In GoogleChatConnectorCallback send the intro message in this method if the dialog is empty.
bot/connector-google-chat/src/main/kotlin/builder/GoogleChatCardMessageBuilders.kt
Show resolved
Hide resolved
| 3600, | ||
| null, | ||
| ) | ||
| } |
There was a problem hiding this comment.
I have red that in the other pull request, rebase it plz.
2 participants
Ticket : DERCBOT-1727
Details
send()flow to dispatch the intro message before the bot’s actual reply when the cooldown allows it.introMessageand exposed it in the connector configuration UI.