Skip to content

Commit 96fbc3a

Browse files
joeltimothyohjoeltimothyoh
committed
Merge branch 'refactor/remove-use-of-psboundparameters' into dev
2 parents b6b828c + 64c35a9 commit 96fbc3a

File tree

5 files changed

+44
-44
lines changed

5 files changed

+44
-44
lines changed

‎src/PSGitHubRestApi/Public/Edit-GitHubRepositoryRelease.ps1‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,21 @@ function Edit-GitHubRepositoryRelease {
4444

4545
begin {
4646
$_apiEndpoint = 'https://api.github.com'
47-
$_uri = "$_apiEndpoint/repos/$($PSBoundParameters['Namespace'])/$($PSBoundParameters['Repository'])/releases/$($PSBoundParameters['ReleaseId'])"
47+
$_uri = "$_apiEndpoint/repos/$($Namespace)/$($Repository)/releases/$($ReleaseId)"
4848
$_headers = @{
49-
Authorization = "token $($PSBoundParameters['ApiKey'])"
49+
Authorization = "token $($ApiKey)"
5050
}
5151
if ($VerbosePreference -ne 'SilentlyContinue') {
5252
$_headersMasked = $_headers.Clone()
5353
$_headersMasked['Authorization'] = "token *******"
5454
}
5555
$_body = [Ordered]@{}
56-
if ($PSBoundParameters['TagName']) { $_body['tag_name'] = $PSBoundParameters['TagName'] }
57-
if ($PSBoundParameters['TargetCommitish']) { $_body['target_commitish'] = $PSBoundParameters['TargetCommitish'] }
58-
if ($PSBoundParameters['Name']) { $_body['name'] = $PSBoundParameters['Name'] }
59-
if ($PSBoundParameters['Body']) { $_body['body'] = $PSBoundParameters['Body'] }
60-
if ($null -ne $PSBoundParameters['Draft']) { $_body['draft'] = $PSBoundParameters['Draft'] }
61-
if ($null -ne $PSBoundParameters['Prerelease']) { $_body['prerelease'] = $PSBoundParameters['Prerelease'] }
56+
if ($TagName) { $_body['tag_name'] = $TagName }
57+
if ($TargetCommitish) { $_body['target_commitish'] = $TargetCommitish }
58+
if ($Name) { $_body['name'] = $Name }
59+
if ($Body) { $_body['body'] = $Body }
60+
if ($null -ne $Draft) { $_body['draft'] = $Draft }
61+
if ($null -ne $Prerelease) { $_body['prerelease'] = $Prerelease }
6262
$_bodyJson = $_body | ConvertTo-Json -Depth 100
6363
"Uri: '$_uri'" | Write-Verbose
6464
"Headers:" | Write-Verbose

‎src/PSGitHubRestApi/Public/Get-GitHubRepositoryRelease.ps1‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ function Get-GitHubRepositoryRelease {
2323

2424
begin {
2525
$_apiEndpoint = 'https://api.github.com'
26-
if ($PSBoundParameters['ReleaseId']) {
27-
$_uri = "$_apiEndpoint/repos/$($PSBoundParameters['Namespace'])/$($PSBoundParameters['Repository'])/releases/$($PSBoundParameters['ReleaseId'])"
28-
}elseif ($PSBoundParameters['All']) {
29-
$_uri = "$_apiEndpoint/repos/$($PSBoundParameters['Namespace'])/$($PSBoundParameters['Repository'])/releases"
26+
if ($ReleaseId) {
27+
$_uri = "$_apiEndpoint/repos/$($Namespace)/$($Repository)/releases/$($ReleaseId)"
28+
}elseif ($All) {
29+
$_uri = "$_apiEndpoint/repos/$($Namespace)/$($Repository)/releases"
3030
}
3131
$_headers = @{
32-
Authorization = "token $($PSBoundParameters['ApiKey'])"
32+
Authorization = "token $($ApiKey)"
3333
}
3434
if ($VerbosePreference -ne 'SilentlyContinue') {
3535
$_headersMasked = $_headers.Clone()

‎src/PSGitHubRestApi/Public/New-GitHubRepository.ps1‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -76,35 +76,35 @@ function New-GitHubRepository {
7676

7777
begin {
7878
$_apiEndpoint = 'https://api.github.com'
79-
$_uri = if ($PSBoundParameters['AccountType'] -eq 'User') {
79+
$_uri = if ($AccountType -eq 'User') {
8080
"$_apiEndpoint/user/repos"
81-
}elseif ($PSBoundParameters['AccountType'] -eq 'Organization') {
82-
"$_apiEndpoint/orgs/$($PSBoundParameters['Namespace'])/repos"
81+
}elseif ($AccountType -eq 'Organization') {
82+
"$_apiEndpoint/orgs/$($Namespace)/repos"
8383
}
8484
$_headers = @{
85-
Authorization = "token $($PSBoundParameters['ApiKey'])"
85+
Authorization = "token $($ApiKey)"
8686
}
8787
if ($VerbosePreference -ne 'SilentlyContinue') {
8888
$_headersMasked = $_headers.Clone()
8989
$_headersMasked['Authorization'] = "token *******"
9090
}
9191
$_body = [Ordered]@{
92-
name = $PSBoundParameters['Repository']
92+
name = $Repository
9393
}
94-
if ($PSBoundParameters['Description']) { $_body['description'] = $PSBoundParameters['Description'] }
95-
if ($PSBoundParameters['Homepage']) { $_body['homepage'] = $PSBoundParameters['Homepage'] }
96-
if ($PSBoundParameters['Private']) { $_body['private'] = $PSBoundParameters['Private'] }
97-
if ($PSBoundParameters['HasIssues']) { $_body['has_issues'] = $PSBoundParameters['HasIssues'] }
98-
if ($PSBoundParameters['HasProjects']) { $_body['has_projects'] = $PSBoundParameters['HasProjects'] }
99-
if ($PSBoundParameters['HasWiki']) { $_body['has_wiki'] = $PSBoundParameters['HasWiki'] }
100-
if ($PSBoundParameters['IsTemplate']) { $_body['is_template'] = $PSBoundParameters['IsTemplate'] }
101-
if ($PSBoundParameters['TeamId']) { $_body['team_id'] = $PSBoundParameters['TeamId'] }
102-
if ($PSBoundParameters['AutoInit']) { $_body['auto_init'] = $PSBoundParameters['AutoInit'] }
103-
if ($PSBoundParameters['GitignoreTemplate']) { $_body['gitignore_template'] = $PSBoundParameters['GitignoreTemplate'] }
104-
if ($PSBoundParameters['LicenseTemplate']) { $_body['license_template'] = $PSBoundParameters['LicenseTemplate'] }
105-
if ($PSBoundParameters['AllowSquashMerge']) { $_body['allow_squash_merge'] = $PSBoundParameters['AllowSquashMerge'] }
106-
if ($PSBoundParameters['AllowMergeCommit']) { $_body['allow_merge_commit'] = $PSBoundParameters['AllowMergeCommit'] }
107-
if ($PSBoundParameters['AllowRebaseMerge']) { $_body['allow_rebase_merge'] = $PSBoundParameters['AllowRebaseMerge'] }
94+
if ($Description) { $_body['description'] = $Description }
95+
if ($Homepage) { $_body['homepage'] = $Homepage }
96+
if ($Private) { $_body['private'] = $Private }
97+
if ($HasIssues) { $_body['has_issues'] = $HasIssues }
98+
if ($HasProjects) { $_body['has_projects'] = $HasProjects }
99+
if ($HasWiki) { $_body['has_wiki'] = $HasWiki }
100+
if ($IsTemplate) { $_body['is_template'] = $IsTemplate }
101+
if ($TeamId) { $_body['team_id'] = $TeamId }
102+
if ($AutoInit) { $_body['auto_init'] = $AutoInit }
103+
if ($GitignoreTemplate) { $_body['gitignore_template'] = $GitignoreTemplate }
104+
if ($LicenseTemplate) { $_body['license_template'] = $LicenseTemplate }
105+
if ($AllowSquashMerge) { $_body['allow_squash_merge'] = $AllowSquashMerge }
106+
if ($AllowMergeCommit) { $_body['allow_merge_commit'] = $AllowMergeCommit }
107+
if ($AllowRebaseMerge) { $_body['allow_rebase_merge'] = $AllowRebaseMerge }
108108
$_bodyJson = $_body | ConvertTo-Json -Depth 100
109109
"Uri: '$_uri'" | Write-Verbose
110110
"Headers:" | Write-Verbose

‎src/PSGitHubRestApi/Public/New-GitHubRepositoryRelease.ps1‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,21 @@ function New-GitHubRepositoryRelease {
4040

4141
begin {
4242
$_apiEndpoint = 'https://api.github.com'
43-
$_uri = "$_apiEndpoint/repos/$($PSBoundParameters['Namespace'])/$($PSBoundParameters['Repository'])/releases"
43+
$_uri = "$_apiEndpoint/repos/$($Namespace)/$($Repository)/releases"
4444
$_headers = @{
45-
Authorization = "token $($PSBoundParameters['ApiKey'])"
45+
Authorization = "token $($ApiKey)"
4646
}
4747
if ($VerbosePreference -ne 'SilentlyContinue') {
4848
$_headersMasked = $_headers.Clone()
4949
$_headersMasked['Authorization'] = "token *******"
5050
}
5151
$_body = [Ordered]@{}
52-
if ($PSBoundParameters['TagName']) { $_body['tag_name'] = $PSBoundParameters['TagName'] }
53-
if ($PSBoundParameters['TargetCommitish']) { $_body['target_commitish'] = $PSBoundParameters['TargetCommitish'] }
54-
if ($PSBoundParameters['Name']) { $_body['name'] = $PSBoundParameters['Name'] }
55-
if ($PSBoundParameters['Body']) { $_body['body'] = $PSBoundParameters['Body'] }
56-
if ($null -ne $PSBoundParameters['Draft']) { $_body['draft'] = $PSBoundParameters['Draft'] }
57-
if ($null -ne $PSBoundParameters['Prerelease']) { $_body['prerelease'] = $PSBoundParameters['Prerelease'] }
52+
if ($TagName) { $_body['tag_name'] = $TagName }
53+
if ($TargetCommitish) { $_body['target_commitish'] = $TargetCommitish }
54+
if ($Name) { $_body['name'] = $Name }
55+
if ($Body) { $_body['body'] = $Body }
56+
if ($null -ne $Draft) { $_body['draft'] = $Draft }
57+
if ($null -ne $Prerelease) { $_body['prerelease'] = $Prerelease }
5858
$_bodyJson = $_body | ConvertTo-Json -Depth 100
5959
"Uri: '$_uri'" | Write-Verbose
6060
"Headers:" | Write-Verbose

‎src/PSGitHubRestApi/Public/New-GitHubRepositoryReleaseAsset.ps1‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ function New-GitHubRepositoryReleaseAsset {
1616
)
1717

1818
begin {
19-
$_matchInfo = $PSBoundParameters['UploadUrl'].Trim() | Select-String -Pattern '(.+\/assets)($|{\?name,label})'
20-
$_uploadUrlProcessed = if ($_matchInfo) { $_matchInfo.Matches.Groups[1].Value } else { $PSBoundParameters['UploadUrl'] }
21-
$_assetItem = Get-Item -Path $PSBoundParameters['Asset'] -ErrorAction Stop
19+
$_matchInfo = $UploadUrl.Trim() | Select-String -Pattern '(.+\/assets)($|{\?name,label})'
20+
$_uploadUrlProcessed = if ($_matchInfo) { $_matchInfo.Matches.Groups[1].Value } else { $UploadUrl }
21+
$_assetItem = Get-Item -Path $Asset -ErrorAction Stop
2222

2323
$_uri = "$($_uploadUrlProcessed)?name=$($_assetItem.Name)"
2424
$_headers = @{
25-
Authorization = "token $($PSBoundParameters['ApiKey'])"
25+
Authorization = "token $($ApiKey)"
2626
"Content-Type" = "application/octet-stream"
2727
}
2828
"Uri: '$_uri'" | Write-Verbose

0 commit comments

Comments
 (0)