This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Support scheduled background task finished #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
michaeldyrynda
force-pushed
the
feature/support-scheduled-background-task-finished
branch
from
f138936 to
bd72b0d
Compare
michaeldyrynda
force-pushed
the
feature/support-scheduled-background-task-finished
branch
from
781b637 to
39a7076
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 8.42 introduced a new
ScheduledBackgroundTaskFinishedevent to more accurately identify when a background task finished running.This PR adds support for that feature, as well as replacing the deprecated
dispatch_nowwithdispatch_sync. Consequently, we'll requirelarave/framework:^8.36once tagged.Unfortunately, because the task runs in the background, we won't have the runtime available, but will be able to calculate it accurately using the timestamp of the
ScheduledBackgroundTaskFinishedping in combination with the already-started execution within thenping.me (thanks to theScheduledTaskStartingevent).