New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: options should be set on the internal options object #8

Open

jonathanong opened this issue May 10, 2015 · 4 comments

Labels

enhancement help wanted

Contributor

jonathanong commented May 10, 2015

so that they persist across requests

jonathanong added enhancement help wanted labels

felixfbecker commented Oct 5, 2015

What do you mean by that? Instead of returning a new request client when request.defaults() is called?

Contributor Author

jonathanong commented Oct 11, 2015

@felixfbecker i don't remember... probably

felixfbecker commented Oct 11, 2015

xD

Contributor Author

jonathanong commented Feb 29, 2016

ok i think this is for two reasons:

easy to set defaults to extend from it
easy to retry a request (needed for retry support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment