Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal component show and hide methods wrong conditional test #516

Open
tpra7 opened this issue Apr 3, 2023 · 0 comments
Open

Modal component show and hide methods wrong conditional test #516

tpra7 opened this issue Apr 3, 2023 · 0 comments

Comments

@tpra7
Copy link

tpra7 commented Apr 3, 2023

Not a bug, it works perfectly, but not conform to the intention.

The show() method of the Modal component use
if ( this.isHidden ) (always returns true, the method exists)
instead of
if ( this.isHidden() ) or if ( this._isHidden )

Same for the hide() method with :
if ( this.isVisible ) (always returns true, the method exists)
instead of
if ( this.isVisible() ) or if ( ! this._isHidden )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant