Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color in darkmode for blockquote & note #1447

Closed
3 tasks done
leirock opened this issue Apr 2, 2020 · 3 comments
Closed
3 tasks done

Color in darkmode for blockquote & note #1447

leirock opened this issue Apr 2, 2020 · 3 comments

Comments

@leirock
Copy link
Contributor

leirock commented Apr 2, 2020

Please follow this Issue template to provide relevant information, such as source code repositories, blog links, and screenshots, which will help us investigate.
请按照此 Issue 模版提供相关信息,例如源码仓库、博客链接和屏幕截图,这将有助于我们进行调查。

Issue Checklist

  • I am using the latest version of NexT.
  • I have read the relevant documents of Hexo and NexT.
  • I have reviewed the latest Roadmap on GitHub and searched for current issues, which does not help me.

Expected behavior

  • For blockquote
    Xnip2020-04-02_16-14-00

  • For note
    Xnip2020-04-02_16-35-17

Actual behavior

  • For blockquote
    Xnip2020-04-02_16-15-10

  • For note
    Xnip2020-04-02_16-34-45

  • Links to demo site with this issue:

  1. blockquote
  2. note

Now I just add custom css to fix it temporarily.

/* blockquote */
.blockquote-center {
  &:before {
    border-top: 1px solid #111;
    filter: invert(100%);
  }
  &:after {
    border-bottom: 1px solid #111;
    filter: invert(100%);
  } 
}

/* note*/
.post-body .note {
  background: var(--body-bg-color) !important;
}

And also the current font color for .blockquote in darkmode is #666, which seems not clear in dark background, so would you please change it to #ccc in darkmode? Thank you!

blockquote {
  color: #ccc;
}

Source code

https://github.com/lei2rock/blog

@leirock leirock added the Bug label Apr 2, 2020
@leirock leirock changed the title Color in darkmode for blockquote Color in darkmode for blockquote & note Apr 2, 2020
@stevenjoezhang
Copy link
Contributor

Fixed in b0bd2dd

About note tag, please use style simple

  note:
    style: simple
    icons: true
    light_bg_offset: -3

@leirock
Copy link
Contributor Author

leirock commented Apr 3, 2020

So currently style flat doesn't support dark mode, right?

I notice that NexT v8 Road Map (#1029) mentions Dark mode color (note flat, pagination) in Known Issues.

@stevenjoezhang
Copy link
Contributor

Yes, I noticed this issue a few days ago. Please join the discussion here #1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants