Refactor to make use of asymmetric visibility #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes all instances of
readonly
for asymmetric visibility, namelypublic private(set)
. Though readonly reads nicely, the reasoning is that if readonly had never been added to PHP, I could achieve anything I want with asymmetric visibility; and I'm happy to have one way of doing things.The only benefit readonly provides is that properties cannot be written to it after having been initialized (typically inside the constructor) - dubbed init-once properties. As the only place I would do that would be inside the given class anyway this feels like needlessly restricting myself.
By using XP Compiler, I can still support all PHP versions >= 7.4 even though asymmetric visibility is PHP 8.4+ feature.
/cc @mikey179