Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to make use of asymmetric visibility #61

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

thekid
Copy link
Owner

@thekid thekid commented Sep 7, 2024

This pull request changes all instances of readonly for asymmetric visibility, namely public private(set). Though readonly reads nicely, the reasoning is that if readonly had never been added to PHP, I could achieve anything I want with asymmetric visibility; and I'm happy to have one way of doing things.

The only benefit readonly provides is that properties cannot be written to it after having been initialized (typically inside the constructor) - dubbed init-once properties. As the only place I would do that would be inside the given class anyway this feels like needlessly restricting myself.

By using XP Compiler, I can still support all PHP versions >= 7.4 even though asymmetric visibility is PHP 8.4+ feature.

/cc @mikey179


⚠️ Tests are failing because the Ubuntu PHP 8.4 build on GitHub Actions is not up-to-date.

@thekid thekid added the refactoring Code refactoring label Sep 7, 2024
@thekid
Copy link
Owner Author

thekid commented Sep 15, 2024

Tests are failing because the Ubuntu PHP 8.4 build on GitHub Actions is not up-to-date.

This has been fixed in the meantime, rerunning the tests now succeeded.

@thekid thekid merged commit ce57956 into main Sep 15, 2024
13 checks passed
@thekid thekid deleted the refactor/asymmetric-visibility branch September 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant