Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Add eslint with mocha rules #554

Open
jacque006 opened this issue Apr 20, 2021 · 1 comment
Open

Add eslint with mocha rules #554

jacque006 opened this issue Apr 20, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jacque006
Copy link
Collaborator

jacque006 commented Apr 20, 2021

What's Wrong

Per #552 (comment) , there are a number of gotcha's such as describe/it.onlys being committed unknowingly. There are likely other code issues we could scan for as well.

How to fix it

@jacque006 jacque006 added the good first issue Good for newcomers label Apr 20, 2021
@jacque006
Copy link
Collaborator Author

Consider: Add check to ensure all equality checks are strict equality. See https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons/359509#359509 for a good opinion on why strict equality is preferable.

tl;dr use ===, !==, enforce via linting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant