You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.
Calling client.printers.all delegates to client.printers.search_all, which in turn delegates to client.printers.search('all'). This doesn't return any printers, except for the default "Save to Google Docs" (__google__docs). I suggest changing method_missing to exclude "all" from the regexp, and then change def all to be an alias on search
The text was updated successfully, but these errors were encountered:
Sorry, my GitHub notification settings were set up so that I didn't get an email when you created this ticket. I'll look into this (and most likely make the changes you suggested) tomorrow.
I've aliased search_all and delegated all as you've suggested. I've also replaced the method missing magic with explicit method definitions. It might be a bit more verbose, but it's a lot easier to reason about.
Also, I've released v0.3.1 of the gem with these changes.
Calling
client.printers.all
delegates toclient.printers.search_all
, which in turn delegates toclient.printers.search('all')
. This doesn't return any printers, except for the default "Save to Google Docs" (__google__docs
). I suggest changingmethod_missing
to exclude "all" from the regexp, and then changedef all
to be an alias onsearch
The text was updated successfully, but these errors were encountered: