Skip to content

Commit 70a9ef4

Browse files
committed
Istanbul ignore else
1 parent 6f85c07 commit 70a9ef4

File tree

4 files changed

+18
-14
lines changed

4 files changed

+18
-14
lines changed

cypress/integration/event-listener.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ describe('EventListener Testing', () => {
3434
}
3535
})
3636
.wait(17)
37-
.get('@body').trigger('click', { force: true }).then((body) => {
38-
expect(body[0].innerHTML).to.equal('<b>click</b>');
37+
.get('b').trigger('click', { force: true }).then((b) => {
38+
expect(b[0].innerHTML).to.equal('<b>click</b>');
3939
expect(EventListener.registry.click).to.be.instanceOf(Map)
4040
})
4141
.wait(17)
42-
.get('b').trigger('click', { force: true }).then((b) => {
43-
expect(b[0].innerHTML).to.equal('<b>click</b>');
42+
.get('@body').trigger('click', { force: true }).then((body) => {
43+
expect(body[0].innerHTML).to.equal('<b>click</b>');
4444
expect(EventListener.registry.click).to.be.instanceOf(Map)
4545
})
4646
});

package-lock.json

Lines changed: 9 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
},
5353
"devDependencies": {
5454
"@bahmutov/cypress-esbuild-preprocessor": "^2.1.3",
55-
"@cypress/code-coverage": "^3.9.12",
55+
"@cypress/code-coverage": "^3.9.12",
5656
"@rollup/plugin-buble": "^0.21.3",
5757
"@rollup/plugin-json": "^4.1.0",
5858
"@rollup/plugin-node-resolve": "^7.1.0",
@@ -63,8 +63,9 @@
6363
"eslint-config-airbnb-base": "^14.2.1",
6464
"eslint-plugin-import": "^2.22.1",
6565
"istanbul-lib-coverage": "^3.2.0",
66-
"istanbul-lib-instrument": "^5.2.0",
66+
"istanbul-lib-instrument": "^5.2.0",
6767
"npm-run-all": "^4.1.5",
68+
"nyc": "^15.1.0",
6869
"rollup": "^2.38.5",
6970
"rollup-plugin-terser": "^5.3.1",
7071
"typescript": "^4.5.2"

src/event-listener.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export function globalListener(e) {
1515

1616
[...EventRegistry[type]].forEach((elementsMap) => {
1717
const [element, listenersMap] = elementsMap;
18+
/* istanbul ignore else */
1819
if ([target, that].some((el) => element === el)) {
1920
[...listenersMap].forEach((listenerMap) => {
2021
const [listener, options] = listenerMap;
@@ -81,6 +82,7 @@ export const removeListener = (element, eventType, listener, options) => {
8182
if (!oneEventMap || !oneEventMap.size) delete EventRegistry[eventType];
8283

8384
// remove listener last
85+
/* istanbul ignore else */
8486
if (!oneElementMap || !oneElementMap.size) {
8587
element.removeEventListener(eventType, globalListener, eventOptions);
8688
}

0 commit comments

Comments
 (0)