-
Notifications
You must be signed in to change notification settings - Fork 70
Migrate away from mock-fs #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thecodrr
wants to merge
3
commits into
master
Choose a base branch
from
chore/migrate-from-mockfs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joinDirectoryPath is now responsible for building directory path instead of building the path in pushDirectory.
this is in preparation for the iterator api which will use opendir. opendir is not supported by mock-fs so we have to move away from it in order to test it properly.
thanks for pinging me, this pr makes 9 tinyglobby tests fail:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
mock-fs
for testing symlinks and some other things. Unfortunately,mock-fs
does not supportopendir
API which will be used by the iterator API we plan on adding in the future. This PR migrates the symlink and other mock-fs dependent tests to use the actual filesystem instead. This has a number of advantages:bindings
Since this PR changes how tests work, it should be tested on some real world cases as well.
cc @SuperchupuDev (would love if you can test this out with tinyglobby)