Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite results in mb_parse_str #269

Closed
wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

Use a different variable for success.
https://www.php.net/manual/en/function.mb-parse-str.php

@dbrekelmans
Copy link
Collaborator

Hi @szepeviktor. While I understand the issue you're trying to fix, this is not the right solution. The file you changed is generated based on the phpdocs. You need to find and resolve the issue in the generator itself. Let me know if you need some pointers!

@szepeviktor
Copy link
Contributor Author

Thank you!

$phpFunction .= ' $result = '.$this->printFunctionCall($method)."\n";

Would $safeResult be okay with you?

@dbrekelmans
Copy link
Collaborator

Sure, I think that's fine :)

@szepeviktor
Copy link
Contributor Author

Done in the next PR.

@szepeviktor szepeviktor closed this Aug 4, 2022
@szepeviktor szepeviktor deleted the patch-1 branch August 4, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants