Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thecodingmachine/safe
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ccbed21d3f6cd56942372fddd0a500adf6385130
Choose a base ref
...
head repository: thecodingmachine/safe
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 843d996ef20e77084a09dfb4191b9156939d52f6
Choose a head ref
  • 8 commits
  • 20 files changed
  • 6 contributors

Commits on Nov 28, 2024

  1. Bring lib/ up to php8.4 standards 

    (Breaking the diff against shish/safe into smaller parts for easier reviewing)
    @shish @staabm
    shish authored and staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f87af02 View commit details
    Browse the repository at this point in the history

  2. Bring deprecated override files up to php8.4 syntax 

    (Breaking shish/safe changes down into smaller changes for easier review)

I also note that many of these are deprecated since php8.0 - at what point do we want to delete them?

Co-authored-by: Ayesh <Ayesh@users.noreply.github.com>
    @shish @Ayesh @staabm
    2 people authored and staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8a6679c View commit details
    Browse the repository at this point in the history

  3. Add auto-regenerate CI workflow 

    (Splitting shish/safe into smaller parts for easier review)

This adds a cronjob which will re-run the auto-generate scripts and send a PR if any changes have been detected.
    @shish @staabm
    shish authored and staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    cf04aca View commit details
    Browse the repository at this point in the history

  4. Use less-old phpstan 

    phpstan 1.5 is very out of date and the API for defining rules is incompatible with the current API.

tests are currently failing, but they're failing upstream and they should pass once all the other PRs are merged

PHPStan 2.0 was released a few days ago, but other parts of our dependency tree are locked to "1.X", so for now I'm just updating to "most recent 1.X" and we can look at 2.0 after the rest is stable.
    @shish @staabm
    shish authored and staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4b73aa4 View commit details
    Browse the repository at this point in the history

  5. Skip json_last_error check when JSON_THROW_ON_ERROR flag is set i… 

    …n `json_decode`
    @marmichalski @staabm
    marmichalski authored and staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b60ee03 View commit details
    Browse the repository at this point in the history

  6. CI: disable fail-fast so we see all results

    @staabm
    staabm committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    c33b6fc View commit details
    Browse the repository at this point in the history

  7. Require PHP 8.1 (#433)

    @simPod
    simPod authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f7eba56 View commit details
    Browse the repository at this point in the history

  8. Bump symfony/process from 4.4.44 to 5.4.46 in /generator 

    Bumps [symfony/process](https://github.com/symfony/process) from 4.4.44 to 5.4.46.
- [Release notes](https://github.com/symfony/process/releases)
- [Changelog](https://github.com/symfony/process/blob/7.1/CHANGELOG.md)
- [Commits](symfony/process@v4.4.44...v5.4.46)

---
updated-dependencies:
- dependency-name: symfony/process
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot
    dependabot[bot] authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    843d996 View commit details
    Browse the repository at this point in the history
Loading