Skip to content

Commit f056e1c

Browse files
author
arp
committed
used psr15 instead of http-interop
1 parent 590dad6 commit f056e1c

File tree

7 files changed

+36
-32
lines changed

7 files changed

+36
-32
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@ language: php
33
php:
44
- 7.0
55
- 7.1
6+
- 7.2
67

78
before_script:
89
- composer install --no-interaction
9-
10+
- mkdir -p build/logs
1011
script:
1112
- phpunit
1213

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"container-interop/service-provider": "^0.4",
3636
"thecodingmachine/common-factories": "^0.4",
3737
"thecodingmachine/middleware-list-universal-module": "~1.0",
38-
"http-interop/http-middleware": "^0.4"
38+
"psr/http-server-middleware": "^1.0"
3939
},
4040
"require-dev": {
4141
"phpunit/phpunit": "^5.0",

src/Mouf/Mvc/Splash/Routers/CacheRouter.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@
22

33
namespace Mouf\Mvc\Splash\Routers;
44

5-
use Interop\Http\ServerMiddleware\DelegateInterface;
6-
use Interop\Http\ServerMiddleware\MiddlewareInterface;
75
use Psr\Http\Message\ResponseInterface;
86
use Psr\Http\Message\ServerRequestInterface;
97
use Mouf\Utils\Cache\CacheInterface;
8+
use Psr\Http\Server\MiddlewareInterface;
9+
use Psr\Http\Server\RequestHandlerInterface;
1010
use Psr\Log\LoggerInterface;
1111
use Mouf\Utils\Common\ConditionInterface\ConditionInterface;
1212

13+
//todo: delete or test
1314
class CacheRouter implements MiddlewareInterface
1415
{
1516
/**
@@ -39,11 +40,11 @@ public function __construct(CacheInterface $cache, LoggerInterface $log, Conditi
3940
* to the next middleware component to create the response.
4041
*
4142
* @param ServerRequestInterface $request
42-
* @param DelegateInterface $delegate
43-
*
43+
* @param RequestHandlerInterface $handler
4444
* @return ResponseInterface
45+
*
4546
*/
46-
public function process(ServerRequestInterface $request, DelegateInterface $delegate)
47+
public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
4748
{
4849
$requestMethod = $request->getMethod();
4950
$key = str_replace(['\\', '/', ':', '*', '?', '"', '<', '>', '|'], '_', $request->getUri()->getPath().'?'.$request->getUri()->getQuery());
@@ -56,7 +57,7 @@ public function process(ServerRequestInterface $request, DelegateInterface $dele
5657
return $cacheResponse;
5758
} else {
5859
$this->log->debug("Cache MISS on key $key");
59-
$response = $delegate->process($request);
60+
$response = $handler->handle($request);
6061

6162
$noCache = false;
6263
if ($response->hasHeader('Mouf-Cache-Control') && $response->getHeader('Mouf-Cache-Control')[0] == 'no-cache') {

src/Mouf/Mvc/Splash/Routers/ExceptionRouter.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
namespace Mouf\Mvc\Splash\Routers;
44

5-
use Interop\Http\ServerMiddleware\DelegateInterface;
6-
use Interop\Http\ServerMiddleware\MiddlewareInterface;
75
use Mouf\Mvc\Splash\Controllers\Http500HandlerInterface;
86
use Psr\Http\Message\ResponseInterface as Response;
97
use Psr\Http\Message\ResponseInterface;
108
use Psr\Http\Message\ServerRequestInterface as Request;
9+
use Psr\Http\Server\MiddlewareInterface;
10+
use Psr\Http\Server\RequestHandlerInterface;
1111
use Psr\Log\LoggerInterface;
1212
use Mouf\Mvc\Splash\Services\SplashUtils;
1313

@@ -77,14 +77,14 @@ function () use ($t, $request) {
7777
* to the next middleware component to create the response.
7878
*
7979
* @param Request $request
80-
* @param DelegateInterface $delegate
8180
*
82-
* @return Response
81+
* @param RequestHandlerInterface $handler
82+
* @return ResponseInterface
8383
*/
84-
public function process(Request $request, DelegateInterface $delegate)
84+
public function process(Request $request, RequestHandlerInterface $handler): ResponseInterface
8585
{
8686
try {
87-
return $delegate->process($request);
87+
return $handler->handle($request);
8888
} catch (\Throwable $t) {
8989
return $this->handleException($t, $request);
9090
}

src/Mouf/Mvc/Splash/Routers/NotFoundRouter.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
namespace Mouf\Mvc\Splash\Routers;
44

5-
use Interop\Http\ServerMiddleware\DelegateInterface;
6-
use Interop\Http\ServerMiddleware\MiddlewareInterface;
75
use Mouf\Mvc\Splash\Controllers\Http404HandlerInterface;
86
use Psr\Http\Message\ResponseInterface as Response;
7+
use Psr\Http\Message\ResponseInterface;
98
use Psr\Http\Message\ServerRequestInterface as Request;
9+
use Psr\Http\Server\MiddlewareInterface;
10+
use Psr\Http\Server\RequestHandlerInterface;
1011
use Psr\Log\LoggerInterface;
1112
use Mouf\Mvc\Splash\Services\SplashUtils;
1213

@@ -41,11 +42,11 @@ public function __construct(Http404HandlerInterface $pageNotFoundController, Log
4142
* to the next middleware component to create the response.
4243
*
4344
* @param Request $request
44-
* @param DelegateInterface $delegate
4545
*
46-
* @return Response
46+
* @param RequestHandlerInterface $handler
47+
* @return ResponseInterface
4748
*/
48-
public function process(Request $request, DelegateInterface $delegate)
49+
public function process(Request $request, RequestHandlerInterface $handler): ResponseInterface
4950
{
5051
if ($this->log) {
5152
$this->log->info('404 - Page not found on URL: '.$request->getUri()->getPath());

src/Mouf/Mvc/Splash/Routers/PhpVarsCheckRouter.php

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
namespace Mouf\Mvc\Splash\Routers;
44

5-
use Interop\Http\ServerMiddleware\DelegateInterface;
6-
use Interop\Http\ServerMiddleware\MiddlewareInterface;
75
use Mouf\Mvc\Splash\Utils\SplashException;
86
use Psr\Http\Message\ResponseInterface as Response;
7+
use Psr\Http\Message\ResponseInterface;
98
use Psr\Http\Message\ServerRequestInterface as Request;
9+
use Psr\Http\Server\MiddlewareInterface;
10+
use Psr\Http\Server\RequestHandlerInterface;
1011
use Psr\Log\LoggerInterface;
1112

1213
/**
@@ -113,12 +114,12 @@ private function countRecursive($item, $key)
113114
* to the next middleware component to create the response.
114115
*
115116
* @param Request $request
116-
* @param DelegateInterface $delegate
117117
*
118-
* @return Response
119-
* @throws \Mouf\Mvc\Splash\Utils\SplashException
118+
* @param RequestHandlerInterface $handler
119+
* @return ResponseInterface
120+
* @throws SplashException
120121
*/
121-
public function process(Request $request, DelegateInterface $delegate)
122+
public function process(Request $request, RequestHandlerInterface $handler): ResponseInterface
122123
{
123124
// Check if there is a limit of input number in php
124125
// Throw exception if the limit is reached
@@ -177,6 +178,6 @@ public function process(Request $request, DelegateInterface $delegate)
177178
}
178179

179180
//If no Exception has been thrown, call next router
180-
return $delegate->process($request);
181+
return $handler->handle($request);
181182
}
182183
}

src/Mouf/Mvc/Splash/Routers/SplashDefaultRouter.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
use Cache\Adapter\Void\VoidCachePool;
66
use Interop\Container\ContainerInterface;
7-
use Interop\Http\ServerMiddleware\DelegateInterface;
8-
use Interop\Http\ServerMiddleware\MiddlewareInterface;
97
use Mouf\Mvc\Splash\Controllers\Http400HandlerInterface;
108
use Mouf\Mvc\Splash\Controllers\Http404HandlerInterface;
119
use Mouf\Mvc\Splash\Controllers\Http500HandlerInterface;
@@ -19,6 +17,8 @@
1917
use Psr\Http\Message\ResponseInterface;
2018
use Psr\Http\Message\ServerRequestInterface;
2119
use Mouf\Mvc\Splash\Store\SplashUrlNode;
20+
use Psr\Http\Server\MiddlewareInterface;
21+
use Psr\Http\Server\RequestHandlerInterface;
2222
use Psr\Log\LoggerInterface;
2323
use Mouf\Mvc\Splash\Services\SplashRequestContext;
2424
use Mouf\Mvc\Splash\Services\SplashUtils;
@@ -409,17 +409,17 @@ public function purgeUrlsCache()
409409
* to the next middleware component to create the response.
410410
*
411411
* @param ServerRequestInterface $request
412-
* @param DelegateInterface $delegate
413412
*
413+
* @param RequestHandlerInterface $handler
414414
* @return ResponseInterface
415415
*/
416-
public function process(ServerRequestInterface $request, DelegateInterface $delegate)
416+
public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
417417
{
418418
// create a dummy response to keep compatibility with old middlewares.
419419
$response = new Response();
420420

421-
return $this($request, $response, function($request) use ($delegate) {
422-
return $delegate->process($request);
421+
return $this($request, $response, function($request) use ($handler) {
422+
return $handler->handle($request);
423423
});
424424
}
425425
}

0 commit comments

Comments
 (0)