Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect path to dvdcli on CoreOS #99

Closed
mitel opened this issue May 7, 2016 · 2 comments
Closed

incorrect path to dvdcli on CoreOS #99

mitel opened this issue May 7, 2016 · 2 comments
Assignees
Milestone

Comments

@mitel
Copy link

mitel commented May 7, 2016

Hello, the library will not work on CoreOS (eg: DC/OS) due to the following:

isolator/isolator/docker_volume_driver_isolator.hpp:
static constexpr char DVDCLI_MOUNT_CMD[] = "/usr/bin/dvdcli mount";
static constexpr char DVDCLI_UNMOUNT_CMD[] = "/usr/bin/dvdcli unmount";

whereas dvdcli will install in /opt/bin on CoreOS:
if [ -n "$IS_COREOS" ]; then
BIN_DIR=/opt/bin
BIN_FILE=$BIN_DIR/$BIN_NAME

@davidvonthenen
Copy link

davidvonthenen commented May 17, 2016

There is a PR #100 ending that should help address this in a generic fashion

@davidvonthenen
Copy link

The PR mentioned above has been merged. We can now specify which DVDCLI to use by fully qualified path per task. If this doesn't meet you requirements, we can revisit the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants