Rethink ThenFactory

[theangrydev]

In practise, the thens assert on not only the response from the when, but also other state such as database interactions and wiremock verifications. There might be a better way of modelling this, because currently there will be ThenFactory implementations that just ignore the response parameter entirely, which is a smell.

[theangrydev]

One way to solve this would be to encourage a test result type that encapsulates the direct result of the when (e.g. a HTTP response) and also other kinds of state. That way, all ThenFactory would always need the same parameter. This could include e.g. HTTP response, database state and wiremock state.

[theangrydev]

Another issue with ThenFactory is when e.g. a wiremock verification needs to be built up. This can't be chained as then(something).hasFoo(1).hasBar(2) because the wiremock verification has to be one blob assertion. A workaround is to have a ThenFactory that is a builder and do something like then(something.hasFoo(1).hasBar(2)) but this is a bit dodgy, there might be a better way?

[theangrydev]

Implemented in 4.0.0