From acffd3d9e657c7013f32665a118772dc1576dfab Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 3 May 2022 01:47:08 +0800 Subject: [PATCH] bootstrap: fix wasm_web_api external reference registration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The external references were not actually registered. PR-URL: https://github.com/nodejs/node/pull/42903 Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Anna Henningsen --- src/node_external_reference.h | 1 + src/node_wasm_web_api.cc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/node_external_reference.h b/src/node_external_reference.h index 306c726631a214..58b8f4bed2fcfd 100644 --- a/src/node_external_reference.h +++ b/src/node_external_reference.h @@ -90,6 +90,7 @@ class ExternalReferenceRegistry { V(uv) \ V(v8) \ V(zlib) \ + V(wasm_web_api) \ V(worker) #if NODE_HAVE_I18N_SUPPORT diff --git a/src/node_wasm_web_api.cc b/src/node_wasm_web_api.cc index fcb845d08b0dfe..1d3febdca6e52b 100644 --- a/src/node_wasm_web_api.cc +++ b/src/node_wasm_web_api.cc @@ -41,6 +41,7 @@ Local WasmStreamingObject::Initialize(Environment* env) { void WasmStreamingObject::RegisterExternalReferences( ExternalReferenceRegistry* registry) { + registry->Register(New); registry->Register(Push); registry->Register(Finish); registry->Register(Abort); @@ -198,6 +199,8 @@ void Initialize(Local target, void RegisterExternalReferences(ExternalReferenceRegistry* registry) { registry->Register(SetImplementation); + registry->Register(StartStreamingCompilation); + WasmStreamingObject::RegisterExternalReferences(registry); } } // namespace wasm_web_api