Skip to content

Commit ae83a79

Browse files
committed
CMake: fix a comment. [skip ci]
We're checking for both pcap_open() and pcap_findalldevs_ex().
1 parent 9ee0608 commit ae83a79

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

CMakeLists.txt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,8 @@ check_function_exists(pcap_dump_ftell64 HAVE_PCAP_DUMP_FTELL64)
725725
# to use when linking.)
726726
#
727727
# This means that check_function_exists() will think that
728-
# the remote-capture APIs are present, including pcap_open().
728+
# the remote-capture APIs are present, including pcap_open()
729+
# and pcap_findalldevs_ex().
729730
#
730731
# However, they are *not* present in macOS Ventura and earlier,
731732
# which means that building on Ventura with Xcode 15 produces
@@ -745,14 +746,14 @@ check_function_exists(pcap_dump_ftell64 HAVE_PCAP_DUMP_FTELL64)
745746
# Given all that, and given that the versions of the
746747
# remote-capture APIs in Sonoma are stubs that always fail,
747748
# there doesn't seem to be any point in checking for pcap_open()
748-
# if we're linking against the Apple libpcap.
749+
# and pcap_findalldevs_ex() if we're linking against the Apple libpcap.
749750
#
750751
# However, if we're *not* linking against the Apple libpcap,
751752
# we should check for it, so that we can use it if it's present.
752753
#
753-
# So we check for pcap_open if 1) this isn't macOS or 2) the
754-
# the libpcap we found is not a system library, meaning that
755-
# its path begins neither with /usr/lib (meaning it's a system
754+
# So we check for pcap_open() and pcap_findalldevs_ex() if 1) this isn't
755+
# macOS or 2) the the libpcap we found is not a system library, meaning
756+
# that its path begins neither with /usr/lib (meaning it's a system
756757
# dylib) nor /Application/Xcode.app (meaning it's a file in
757758
# the Xcode SDK).
758759
#

0 commit comments

Comments
 (0)