Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full models for optional data #41

Open
AA-Turner opened this issue Apr 7, 2021 · 1 comment
Open

Full models for optional data #41

AA-Turner opened this issue Apr 7, 2021 · 1 comment

Comments

@AA-Turner
Copy link
Member

In ci.schemas.member.MemberDetails, disabilities, hobbies, and qualifications are currently implemented as a simple dict str -> str. The fields are implemented in Compass in such a way that only one entry of each subtype (e.g. A Levels, Degree (eg BA, BSC), Doctorate) is allowd, enabling using a dict in Python.

This would also feasibly enable using a full pydantic model, but I somewhat question the usecase -- it would be ~60 lines for the three models, increasing the size of schemas.members by 12%. Willing to consider it if someone has a use, but for now will leave this issue open as a marker.

@AA-Turner
Copy link
Member Author

AA-Turner commented Apr 7, 2021

@AA-Turner AA-Turner transferred this issue from the-scouts/compass-interface-core Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant