Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_upstream_http_request hook not called for sources with type = federation #432

Closed
aarne opened this issue Feb 11, 2024 · 2 comments · Fixed by #440
Closed

on_upstream_http_request hook not called for sources with type = federation #432

aarne opened this issue Feb 11, 2024 · 2 comments · Fixed by #440
Assignees
Labels
bug Something isn't working

Comments

@aarne
Copy link

aarne commented Feb 11, 2024

config:

sources:
    - type: federation
      id: whatever
      config:
          supergraph:
              file: supergraph.graphql

endpoints:
    - path: /graphql
      from: whatever
      plugins:
          - type: "vrl"
            config:
                on_downstream_http_request:
                    from: inline
                    content: |
                        log("on_downstream_http_request", level:"info")

                on_upstream_http_request:
                    from: inline
                    content: |
                        log("on_upstream_http_request", level:"info")

                on_downstream_http_response:
                    from: inline
                    content: |
                        log("on_downstream_http_response", level:"info")

                on_downstream_graphql_request:
                    from: inline
                    content: |
                        log("on_downstream_graphql_request", level:"info")

output:

2024-02-11T14:24:08.605823Z  INFO vrl::stdlib::log: on_downstream_http_request internal_log_rate_secs=1 vrl_position=0
2024-02-11T14:24:08.60589Z  INFO vrl::stdlib::log: on_downstream_graphql_request internal_log_rate_secs=1 vrl_position=0
2024-02-11T14:24:08.633743Z  INFO vrl::stdlib::log: on_downstream_http_response internal_log_rate_secs=1 vrl_position=0

Log for on_upstream_http_request is missing

@dotansimha
Copy link
Member

dotansimha commented Feb 11, 2024

Hi @aarne ! Thank you for reporting this issue.
We are working on a fix :)

@dotansimha
Copy link
Member

Fixed in v0.0.6-alpha.0 @aarne :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants