Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Rename eventsCategory to eventCategory #21

Open
justlevine opened this issue Dec 6, 2020 · 0 comments
Open

[Feature Request] Rename eventsCategory to eventCategory #21

justlevine opened this issue Dec 6, 2020 · 0 comments

Comments

@justlevine
Copy link
Contributor

justlevine commented Dec 6, 2020 •
edited
Loading

I'd like to rename eventsCategory to eventCategory (and eventsCategories to eventCategories.
It would follow the standard nomenclature {singleGraphqlName}{Taxonomy} and bring it in line with other WPGraphQL projects (e.g. woocommerce).
Also, it's more intuitive for native english speakers.

It's a breaking change, but this plugin is early on enough that it shouldnt matter?

I'm happy to submit a PR if you agree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justlevine