Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.24.0 rc.1 #4935

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Cut 0.24.0 rc.1 #4935

merged 3 commits into from
Dec 9, 2021

Conversation

squat
Copy link
Member

@squat squat commented Dec 8, 2021

Cherry-pick #4928 and cut v0.24.0-rc.1

`getContainerURL` was creating a new `http.Client` within `HTTPSender`.
This increased memory pressure on components making requests to Azure.

Move `http.Client` creation out of `HTTPSender`, only creating it once
per call to `getContainerURL`.

Signed-off-by: Andrew Seigner <andrew@sig.gy>
@squat squat requested a review from a team December 8, 2021 23:53
@yeya24
Copy link
Contributor

yeya24 commented Dec 9, 2021

Can we update the changelog mentioned #4910 (comment)?

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@squat squat merged commit 0eda56a into thanos-io:release-0.24 Dec 9, 2021
@squat squat deleted the cut_0.24.0-rc.1 branch December 9, 2021 10:12
@pstibrany
Copy link
Contributor

Just a reminder: when merging release-0.24 back to main, please use "Merge" commit, not Squash merge. Goal is to make release tags "reachable" from main branch, to make versioning in go.mod work properly. Thank you! (See #4770 for details, currently discussed at cortexproject/cortex#4585 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants