Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup index reader requests #6537

Open
GiedriusS opened this issue Jul 19, 2023 · 1 comment
Open

Dedup index reader requests #6537

GiedriusS opened this issue Jul 19, 2023 · 1 comment

Comments

@GiedriusS
Copy link
Member

Is your proposal related to a problem?

Typically, in a Grafana dashboard you will see a bunch of queries related to one app so label matchers typically overlap. This is especially the case with variables such as env or app. So, if, let's say, env is a high cardinality label then opening a Grafana dashboard with 10 panels that have ...{env="prod"} will load postings for env="prod" 10 times if we are unlucky.

Describe the solution you'd like

If there is more than one call to expand env="prod" postings for some block then the others should wait until the other finishes. If the previous request times out or errors out then we should try doing this again.

Describe alternatives you've considered

Groupcache kind of handles this for us natively but it would be cool to have such mechanism in general enabled by default locally.

Additional context

N/A

@yeya24
Copy link
Contributor

yeya24 commented Jul 21, 2023

I think you attempted the same issue before? @GiedriusS
Do you think the expanded posting cache helps here? I think it doesn't address the issue but should help a little bit here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants