Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging package to use grpc-middleware v2.0.0-rc.3 #5781

Open
metalmatze opened this issue Oct 10, 2022 · 2 comments
Open

Update logging package to use grpc-middleware v2.0.0-rc.3 #5781

metalmatze opened this issue Oct 10, 2022 · 2 comments

Comments

@metalmatze
Copy link
Contributor

If we update github.com/grpc-ecosystem/go-grpc-middleware/v2 to v2.0.0-rc.3 it breaks in the pkg/logging package, as the package github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/tags doesn't exist anymore.

We should update the Thanos logging package accordingly.

cc @manojVivek for discovering this.

@avinilcodes
Copy link

@metalmatze I am willing to contribute, Can i take it up? I would have some questions here and there while understanding and in dev phase please guide accordingly. Please assign this to me

@metalmatze
Copy link
Contributor Author

Go for it. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants