Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace crypto/sha256 with github.com/minio/sha256-simd #5722

Closed
yeya24 opened this issue Sep 25, 2022 · 5 comments
Closed

replace crypto/sha256 with github.com/minio/sha256-simd #5722

yeya24 opened this issue Sep 25, 2022 · 5 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Sep 25, 2022

Is your proposal related to a problem?

Currently crypto/sha256 is mainly used for calculating hash of files we upload/download to/from the object store.
As shown from https://github.com/minio/sha256-simd, the performance is much better than crypto/sha256 in golang.

Describe the solution you'd like

Simply replace the library.

Additional context

Thanos also builds images for other arches like freebsd and ppc64le, those might not be supported.

@utukJ
Copy link
Contributor

utukJ commented Sep 28, 2022

Hi @yeya24. Does this work? #5738

@yeya24
Copy link
Contributor Author

yeya24 commented Sep 28, 2022

@utukJ Thank you, I think that works.
Have you verified, does it work for all archs? For unsupported arch, does it still work like fallbacking into the stdlib.

@utukJ
Copy link
Contributor

utukJ commented Sep 29, 2022

Thanks for the feedback @yeya24 . I've fixed the import grouping you mentioned. However, I'm not sure how to verify this:

Have you verified, does it work for all archs? For unsupported arch, does it still work like fallbacking into the stdlib.

@matej-g
Copy link
Collaborator

matej-g commented Sep 30, 2022

I guess you'd have to try and build an image for one of the mentioned unsupported archs:

Thanos also builds images for other arches like freebsd and ppc64le, those might not be supported.

@bwplotka
Copy link
Member

Fixed in #5738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants