-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace crypto/sha256 with github.com/minio/sha256-simd #5722
Comments
@utukJ Thank you, I think that works. |
Thanks for the feedback @yeya24 . I've fixed the import grouping you mentioned. However, I'm not sure how to verify this:
|
I guess you'd have to try and build an image for one of the mentioned unsupported archs:
|
Fixed in #5738 |
Is your proposal related to a problem?
Currently
crypto/sha256
is mainly used for calculating hash of files we upload/download to/from the object store.As shown from https://github.com/minio/sha256-simd, the performance is much better than
crypto/sha256
in golang.Describe the solution you'd like
Simply replace the library.
Additional context
Thanos also builds images for other arches like
freebsd
andppc64le
, those might not be supported.The text was updated successfully, but these errors were encountered: