Give guidance that memcached should not be configured on loadbalancer level

[wiardvanrij]

The

config:
  addresses: []

Can be used in various ways. It should be clear that each memcached instance should be defined, rather than a 'main' instance E.g. "loadbalancer" adres. This is because the client does not do autodiscovery (Correct me if I'm wrong): https://docs.aws.amazon.com/AmazonElastiCache/latest/mem-ug/AutoDiscovery.HowAutoDiscoveryWorks.html

Plan

I will update the documentation to make this clear

[kakkoyun]

AFAIK you can use DNS service discovery or you can specify all. i.e

thanos/pkg/cacheutil/memcached_client.go

Line 81 in befb025

// Addresses specifies the list of memcached addresses. The addresses get

Kubernetes e.g https://github.com/observatorium/deployments/blob/258c17c7889351cc7366a5c3b6162ad216d666d0/components/thanos.libsonnet#L241

@pstibrany @pracucci would know better.

But yes, let's improve documentation on this.

[wiardvanrij]

Right, thanks @kakkoyun . I will include that as well. It's important to either use such DNS discovery or define the single targets yourself (in case of for example AWS). If you only define the k8s svc, you are going to have a bad time :)

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.