Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Update dependencies for the React UI #3811

Closed
onprem opened this issue Feb 17, 2021 · 5 comments · Fixed by #3813
Closed

ui: Update dependencies for the React UI #3811

onprem opened this issue Feb 17, 2021 · 5 comments · Fixed by #3813
Labels
component: UIs/ReactJS difficulty: easy good first issue

Comments

@onprem
Copy link
Member

onprem commented Feb 17, 2021

The node dependencies are quite out-of-date for the React UI, let's update to the latest version we can without breaking anything.
@onprem onprem mentioned this issue Feb 17, 2021
Closed
@saswatamcode
Copy link
Member

I would love to take this up! This issue would involve upgrading all deps to their latest releases and dealing with any code changes that requires, right?

@ruddi10
Copy link

ruddi10 commented Feb 18, 2021

@prmsrswt can I work on it?

@onprem
Copy link
Member Author

onprem commented Feb 18, 2021

@saswatamcode yep that's exactly what is needed.

@ruddi10 Let's wait for @saswatamcode first and try to not have duplicated effort.

@saswatamcode saswatamcode mentioned this issue Feb 19, 2021
Merged
@saswatamcode
Copy link
Member

@prmsrswt would love it if you can take a look at this and suggest some changes. I've upgraded the dependencies as much as possible, but some tests fail due to the upgrades and I'm not familiar with the testing architecture of the project yet. Also certain caveats exist due to these changes.

@onprem onprem linked a pull request Mar 1, 2021 that will close this issue
Update ui npm dependencies to latest versions #3813
Merged
@onprem
Copy link
Member Author

onprem commented Mar 1, 2021 •
edited
Loading

Closing as this got fixed in #3813

@onprem onprem closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: UIs/ReactJS difficulty: easy good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ui npm dependencies to latest versions saswatamcode/thanos
3 participants
@onprem @saswatamcode @ruddi10