Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Viewer: Show some additional stats #3219

Open
onprem opened this issue Sep 24, 2020 · 21 comments
Open

Block Viewer: Show some additional stats #3219

onprem opened this issue Sep 24, 2020 · 21 comments

Comments

@onprem
Copy link
Member

onprem commented Sep 24, 2020

We can show some more information in the Block Viewer:

  • Last refresh time: it's already available in the API response
  • Total number of blocks (across all sources)
  • Total number of blocks in each group
  • Number of overlapping blocks (in each row/group and overall)
  • Which blocks are currently being compacted/downsampled (makes sense only when the Block Viewer is run from compactor)
@aribalam
Copy link
Contributor

@prmsrswt How would you like to display block statistics for each group? I was thinking of displaying it in the right sidebar similar to that of each block.

@onprem
Copy link
Member Author

onprem commented Sep 26, 2020

Hmm, that can work. Currently, I don't have a design in my mind, it'd be great if you can figure out something.

@daksh-sagar
Copy link
Contributor

@aribalam I've opened a PR that takes care of the first 3 points so you might want to skip them.
cc: @prmsrswt

@stale
Copy link

stale bot commented Nov 26, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Nov 26, 2020
@onprem onprem removed the stale label Nov 26, 2020
@stale
Copy link

stale bot commented Jan 25, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 25, 2021
@yeya24
Copy link
Contributor

yeya24 commented Jan 26, 2021

Still valid.

@ruddi10
Copy link

ruddi10 commented Feb 18, 2021

@kakkoyun @prmsrswt Can I take up this issue?

@onprem
Copy link
Member Author

onprem commented Feb 18, 2021

@ruddi10 sure, there's some on-going work around this issue so just keep those in mind.

@ruddi10
Copy link

ruddi10 commented Feb 18, 2021

@prmsrswt There are no linked pull requests with this issue. So if you can please tell me what all is completed

@onprem
Copy link
Member Author

onprem commented Feb 18, 2021

There's this PR which handles quite a few of them: #3467

@stale
Copy link

stale bot commented Jun 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 3, 2021
@kakkoyun
Copy link
Member

kakkoyun commented Jun 3, 2021

Still valid.

@stale stale bot removed the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Aug 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 2, 2021
@onprem onprem removed the stale label Aug 14, 2021
@stale
Copy link

stale bot commented Oct 30, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 30, 2021
@yeya24 yeya24 removed the stale label Oct 30, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 2, 2022
@matej-g matej-g reopened this Mar 3, 2022
@stale stale bot removed the stale label Mar 3, 2022
@stale
Copy link

stale bot commented May 2, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 2, 2022
@GiedriusS GiedriusS added dont-go-stale Label for important issues which tells the stalebot not to close them and removed stale labels May 2, 2022
@adithyaakrishna
Copy link

@GiedriusS Can I work on this? 👀

I guess there's a PR #3467 which can be used as the base 😶

@GiedriusS
Copy link
Member

Yep! Feel free to ask any questions if you have any.

@sagnik3788
Copy link
Contributor

@GiedriusS has this issue been resolved? If not, may I take up this task?

@yeya24
Copy link
Contributor

yeya24 commented Dec 4, 2023

@sagnik3788 Just go for it as I believe no one is working on this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants