Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos UI Enhancements #3142

Open
squat opened this issue Sep 8, 2020 · 18 comments
Open

Thanos UI Enhancements #3142

squat opened this issue Sep 8, 2020 · 18 comments

Comments

@squat
Copy link
Member

squat commented Sep 8, 2020

The Thanos project has recently migrated its UI to one built on re-usable and shareable components written in React, with the goal of fostering collaboration with the broader Prometheus community. We would like to propose enhancements to the UI to better surface information in every Thanos component. This includes: exposing build- and run-time configuration; creating an API discovery page to provide living documentation of all of the endpoints exposed by Thanos components; and adding benchmarks for the UI. These enhancements all have the additional benefit of being relevant to and useful in the Prometheus project. As part of this proposal, we would like to further collaborate with the Prometheus community to continue building a shared UI component library and to contribute upstream to Prometheus so that it can leverage these components in its UI.

cc @thanos-io/thanos-maintainers
cc @prmsrswt

@stale
Copy link

stale bot commented Nov 30, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Nov 30, 2020
@kakkoyun kakkoyun removed the stale label Nov 30, 2020
@stale
Copy link

stale bot commented Jan 30, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 30, 2021
@kakkoyun
Copy link
Member

kakkoyun commented Feb 9, 2021

Still valid. Wait for #3423 #3316 to get merged.
cc @prmsrswt @Oghenebrume50

@kakkoyun kakkoyun removed the stale label Feb 9, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 3, 2021
@kakkoyun kakkoyun removed the stale label Jun 11, 2021
@anuraagbarde
Copy link

Hello there! I have experience with working in React, as this is marked as good first issue how can I contribute? Thanks.

@Nexucis
Copy link
Contributor

Nexucis commented Jul 2, 2021

Hello,

After doing a couple of PR to report the changes done on Prometheus side, in Thanos, definitely sharing component / service / pages would be great so we don't have to do the job twice.

On the prometheus point of view, it would be painful to put the different shared component outside of the Prometheus repository.
So we could create one or multiple shared package in the Prometheus repository that then can be used directly in Prometheus without waiting for the release of each package (probably using the local path linked in the package.json of the react-app)

I think we could have something like that:

prometheus/prometheus
  |
  |
  ------ web/ui/shared
          |
          |
          -------- package.json
          |
          |
          -------- index.ts
          |
          |
          ------- services
         |         |
         |         |
         |         ----- prometheus.ts // http client that matches the prometheus API
         |
         -------- components
                   |
                   |
                   ----- flag.ts // a page to display the flag 

Regarding the versioning, we can release the package @prometheus/shared (didn't find better name) every 6 weeks when prometheus is released with the same version (currently v2.28)

WDYT @juliusv @onprem ?

/cc @bwplotka @roidelapluie

@Nexucis
Copy link
Contributor

Nexucis commented Jul 2, 2021

and not sure it's really a good first issue. But that's maybe just me haha.

@stale
Copy link

stale bot commented Sep 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Sep 3, 2021
@Nexucis
Copy link
Contributor

Nexucis commented Sep 7, 2021

On prometheus side we are starting to make some changes in the way the UI is managed.
We are currently looking at using the npm workspace. It will ease the usage of local npm package. We are starting with codemirror-promql.

Moving to npm workspace required many update and changes. It will take some times to have it in place.
But once it is done, it will be probably interesting to create a new npm module that would be common between Prometheus and Thanos

The move to npm workspace is handled through this PR: prometheus/prometheus#9227

@stale stale bot removed the stale label Sep 7, 2021
@Nexucis
Copy link
Contributor

Nexucis commented Sep 26, 2021

We finally finished to move to the npm workspace on Prometheus side.

Probably it will make sense to start with #4685 in order to have a common module between Prometheus and thanos managing the PromQL expression

@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@GiedriusS GiedriusS removed the stale label Jan 10, 2022
@yeya24
Copy link
Contributor

yeya24 commented Jan 10, 2022

Still valid

@stale
Copy link

stale bot commented Apr 16, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 30, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Apr 30, 2022
@GiedriusS GiedriusS reopened this Apr 30, 2022
@stale stale bot removed the stale label Apr 30, 2022
@keremgocen
Copy link

happy to take a look 👀

@keremgocen
Copy link

I traced it until open-telemetry/wg-prometheus#63 but I could use hints on what the next step would be today (cc: @Nexucis)

@stale
Copy link

stale bot commented Jul 31, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 31, 2022
@sagnik3788
Copy link
Contributor

@GiedriusS anyone working on it ?

@stale stale bot removed the stale label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants