Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: Ensure Dashboard Vars Depending on LabelNames; LabelValues; Series are limited to certain time period / Add ability to set default in querier #3119

Closed
bwplotka opened this issue Sep 3, 2020 · 13 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Sep 3, 2020

Currently unlimited time range for Label and LabelValues and Series Thanos APIs return and touch all the data as .. expected. This is great, but it does not make much sense for most of the cases.

We recently added time range parameters to those API endpoints for both Thanos & Prometheus: #1811 However we need to make sure that Grafana utilizes those. Otherwise Grafana always load years worth of series and labels every time params are refreshed.

Let's:

  1. Add issue on Grafana side
  2. Allow setting a sane default if time params are not specified. This is what Cortex team is doing - they allow fetching last 2h for non specified time ranges.

We also expect those endpoints to be cached in next iterations of Query Frontend (cc @kakkoyun ) but still this issue is valid.

Help wanted (:

@bwplotka bwplotka changed the title grafanaquerier: Limit LabelNames; LabelValues to certain time period. grafanaquerier: Limit LabelNames; LabelValues to certain time period / Limit it artificially if no limit is specified on querier Sep 3, 2020
@bwplotka bwplotka changed the title grafanaquerier: Limit LabelNames; LabelValues to certain time period / Limit it artificially if no limit is specified on querier grafana: Limit Dashboard vars depending on LabelNames; LabelValues; Series to certain time period / Add ability to set default in querier Sep 3, 2020
@bwplotka bwplotka changed the title grafana: Limit Dashboard vars depending on LabelNames; LabelValues; Series to certain time period / Add ability to set default in querier grafana: Ensure Dashboard Vars Depending on LabelNames; LabelValues; Series are limited to certain time period / Add ability to set default in querier Sep 3, 2020
@kakkoyun
Copy link
Member

xref: grafana/grafana#11184

@kakkoyun
Copy link
Member

kakkoyun commented Sep 11, 2020

Add issue on Grafana side

xref: grafana/grafana#27537 and PR (WIP): grafana/grafana#27548

@kakkoyun
Copy link
Member

Allow setting a sane default if time params are not specified. This is what Cortex team is doing - they allow fetching last 2h for non specified time ranges.

#3147

@stale
Copy link

stale bot commented Nov 11, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Nov 11, 2020
@kakkoyun kakkoyun removed the stale label Nov 11, 2020
@kakkoyun
Copy link
Member

I'll handle what's left for this issue soon.

@stale
Copy link

stale bot commented Jan 10, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 10, 2021
@kakkoyun kakkoyun removed the stale label Jan 12, 2021
@kakkoyun
Copy link
Member

/remind me to finish this in a week

@stale
Copy link

stale bot commented Mar 16, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Mar 16, 2021
@yeya24
Copy link
Contributor

yeya24 commented Mar 16, 2021

@kakkoyun Was this issue solved already by #3147?

@stale stale bot removed the stale label Mar 16, 2021
@kakkoyun
Copy link
Member

@yeya24 Only a minor part is left, we need to adjust the default values for the interval. I want to do it for 0.20.

/remind me to finish this next Monday

@stale
Copy link

stale bot commented Jun 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 2, 2021
@kakkoyun kakkoyun removed the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Aug 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 2, 2021
@stale
Copy link

stale bot commented Aug 17, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants