Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket: Add timeout to thanos bucket inspect #1532

Closed
jdfalk opened this issue Sep 17, 2019 · 0 comments · Fixed by #1533
Closed

Bucket: Add timeout to thanos bucket inspect #1532

jdfalk opened this issue Sep 17, 2019 · 0 comments · Fixed by #1533

Comments

@jdfalk
Copy link
Contributor

jdfalk commented Sep 17, 2019

Thanos, Prometheus and Golang version used

buildsys:~/repos/gocode/src/github.com/jdfalk/thanos$ ./thanos --version
thanos, version 0.7.0 (branch: master, revision: bfb5645)
build user: builduser@buildsys
build date: 20190917-13:59:50
go version: go1.13

What happened
thanos bucket web supports a timeout value but thanos bucket inspect does not.

What you expected to happen
Both would have timeout options.

How to reproduce it (as minimally and precisely as possible):
Default build

Anything else we need to know
I'll create a pull request to add the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant