You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I need to inject some environment variables to all Thanos pods (to configure tracing). Considering this is currently not supported by the lib I'll be probably doing this by patching multiple components in the generated json.
Would adding support for it be something you'd be interested in? I'm happy to prepare a PR
For example, for kube-thanos-store it could be something like:
Just realized that tracing in Thanos is configured via cli flags, not via env vars (e.g. https://github.com/jaegertracing/jaeger-client-go#environment-variables ) . I won't need this to move on with my config change, but if others find it useful I can still create a PR. Otherwise the issue can be closed.
I need to inject some environment variables to all Thanos pods (to configure tracing). Considering this is currently not supported by the lib I'll be probably doing this by patching multiple components in the generated json.
Would adding support for it be something you'd be interested in? I'm happy to prepare a PR
For example, for kube-thanos-store it could be something like:
not sure who the maintainers are, pinging @yeya24 @brancz @metalmatze for some feedback
The text was updated successfully, but these errors were encountered: