Merge pull request #12 from sovren/feature/property-name-changes

Feature/property name changes

Author: sovren-jwesson

.github/workflows/maven-publish.yml

@@ -4,8 +4,8 @@
 name: Maven Package Publish
 
 on:
-  push:
-    branches: [ master ]
+  release:
+    types: [created]
 
 jobs:
   build:

pom.xml

@@ -4,7 +4,7 @@
     <groupId>com.sovren</groupId>
     <artifactId>sovren-java</artifactId>
 
-    <version>0.1.11-beta</version>
+    <version>0.1.12-beta</version>
 
     <packaging>jar</packaging>
     <name>Sovren Java SDK</name>

src/main/java/com/sovren/models/resume/metadata/ResumeSection.java

@@ -5,19 +5,21 @@
 
 package com.sovren.models.resume.metadata;
 
+import com.sovren.models.ParsedDocumentMetadata;
+
 /**
 * A section in the resume (work history, education, etc)
 */
 public class ResumeSection {
 
-    /** The first line of the section (zero-based)*/
-    public int FirstLine;
+    /** The first line of the section (zero-based). This refers to the lines (delimited by newline) in the {@link ParsedDocumentMetadata#PlainText} */
+    public int FirstLineNumber;
 
-    /** The last line of the section (zero-based)*/
-    public int LastLine;
+    /** The last line of the section (zero-based). This refers to the lines (delimited by newline) in the {@link ParsedDocumentMetadata#PlainText} */
+    public int LastLineNumber;
 
     /**
-     * The type of section. Some possibilites:
+     * The type of section. Some possibilities:
      * <ul>
      * <li>CONTACT_INFO</li>
      * <li>EDUCATION</li>
@@ -34,5 +36,5 @@ public class ResumeSection {
      * The exact text that was used to identify the beginning of the section.
      * If there was no text indicator and the location was calculated, then the value is {@code "CALCULATED"}
     */
-    public String HeaderFound;
+    public String HeaderTextFound;
 }

src/test/java/com/sovren/integration/ParsingTests.java

@@ -485,7 +485,7 @@ public void testGeneralOutput() throws Exception {
         assertNotNull(response.Value.ResumeData.ResumeMetadata.FoundSections);
         assertHasItems(response.Value.ResumeData.ResumeMetadata.FoundSections);
         assertNotNull(response.Value.ResumeData.ResumeMetadata.FoundSections.get(0).SectionType);
-        assertNotEquals(0, response.Value.ResumeData.ResumeMetadata.FoundSections.get(0).LastLine);
+        assertNotEquals(0, response.Value.ResumeData.ResumeMetadata.FoundSections.get(0).LastLineNumber);
         assertNotNull(response.Value.ResumeData.ResumeMetadata.ReservedData);
         assertNotNull(response.Value.ResumeData.ResumeMetadata.SovrenSignature);
         assertNotNull(response.Value.ResumeData.ResumeMetadata.ParserSettings);