Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MovePlayer function #1320

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

KVonGit
Copy link
Collaborator

@KVonGit KVonGit commented Dec 29, 2024

Closes #1297

Currently to move the player you have to move game.pov, and this is commonly confused with the ChangePOV function. So let's add a "move player" function to live alongside "move object", which should be nice and easy to find.

  • Alex

Closes textadventures#1297

> Currently to move the player you have to move game.pov, and this is commonly confused with the ChangePOV function. So let's add a "move player" function to live alongside "move object", which should be nice and easy to find.
- Alex
@KVonGit
Copy link
Collaborator Author

KVonGit commented Dec 29, 2024

This modifies EditorEnglish.aslx, and so does #1316

Closing this, to resubmit after the previous PR is finalized.

@KVonGit KVonGit closed this Dec 29, 2024
@KVonGit
Copy link
Collaborator Author

KVonGit commented Dec 29, 2024

#1316 has been closed without merging.

So, reopening this, since there will no longer be a conflict.

@KVonGit KVonGit reopened this Dec 29, 2024
@alexwarren
Copy link
Contributor

I don't think there would have been a conflict here by the way, as they were two different parts of the same file, and git is usually pretty good at handling that situation.

@alexwarren alexwarren merged commit 9a66cbb into textadventures:master Dec 29, 2024
@KVonGit KVonGit deleted the MovePlayer branch December 29, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "move player" function
2 participants