Skip to content

Commit cf1e959

Browse files
yskim1501tex3d
authored andcommitted
fixing issue with DxilContainerBuilder tests (#2)
Fix ASSERT from CComPtr by adding Release() calls before reusing IDxcOperationResult
1 parent 04e285d commit cf1e959

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tools/clang/unittests/HLSL/CompilerTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1375,6 +1375,7 @@ TEST_F(CompilerTest, CompileWhenDebugWorksThenStripDebug) {
13751375
VERIFY_SUCCEEDED(CreateContainerBuilder(&pBuilder));
13761376
VERIFY_SUCCEEDED(pBuilder->Load(pProgram));
13771377
VERIFY_SUCCEEDED(pBuilder->RemovePart(hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
1378+
pResult.Release();
13781379
VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
13791380
VERIFY_SUCCEEDED(pResult->GetResult(&pNewProgram));
13801381
pHeader = (hlsl::DxilContainerHeader *)(pNewProgram->GetBufferPointer());
@@ -1407,6 +1408,7 @@ TEST_F(CompilerTest, CompileWhenWorksThenAddRemovePrivate) {
14071408
CreateBlobFromText(privateTxt.c_str(), &pPrivate);
14081409
VERIFY_SUCCEEDED(pBuilder->Load(pProgram));
14091410
VERIFY_SUCCEEDED(pBuilder->AddPart(hlsl::DxilFourCC::DFCC_PrivateData, pPrivate));
1411+
pResult.Release();
14101412
VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
14111413

14121414
CComPtr<IDxcBlob> pNewProgram;
@@ -1425,6 +1427,7 @@ TEST_F(CompilerTest, CompileWhenWorksThenAddRemovePrivate) {
14251427
VERIFY_SUCCEEDED(CreateContainerBuilder(&pBuilder));
14261428
VERIFY_SUCCEEDED(pBuilder->Load(pNewProgram));
14271429
VERIFY_SUCCEEDED(pBuilder->RemovePart(hlsl::DxilFourCC::DFCC_PrivateData));
1430+
pResult.Release();
14281431
VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
14291432

14301433
pNewProgram.Release();
@@ -1468,6 +1471,7 @@ TEST_F(CompilerTest, CompileWithRootSignatureThenStripRootSignature) {
14681471
VERIFY_SUCCEEDED(CreateContainerBuilder(&pBuilder));
14691472
VERIFY_SUCCEEDED(pBuilder->Load(pProgram));
14701473
VERIFY_SUCCEEDED(pBuilder->RemovePart(hlsl::DxilFourCC::DFCC_RootSignature));
1474+
pResult.Release();
14711475
VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
14721476
VERIFY_SUCCEEDED(pResult->GetResult(&pNewProgram));
14731477
pContainerHeader = (hlsl::DxilContainerHeader *)(pNewProgram->GetBufferPointer());

0 commit comments

Comments
 (0)