Support Apple Silicon

[fiibbb]

Currently tapping this repo with brew tap on a Apple silicon (m1) machine fails with the following:

> brew tap tetratelabs/getenvoy
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> Updated Formulae
Updated 3 formulae.

==> Tapping tetratelabs/getenvoy
Cloning into '/opt/homebrew/Library/Taps/tetratelabs/homebrew-getenvoy'...
remote: Enumerating objects: 106, done.
remote: Counting objects: 100% (106/106), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 214 (delta 22), reused 63 (delta 14), pack-reused 108
Receiving objects: 100% (214/214), 48.15 KiB | 1.85 MiB/s, done.
Resolving deltas: 100% (44/44), done.
Error: Invalid formula: /opt/homebrew/Library/Taps/tetratelabs/homebrew-getenvoy/Formula/getenvoy.rb
formulae require at least a URL
Error: Cannot tap tetratelabs/getenvoy: invalid syntax in tap!

Judging by source, this is intentionally disabled but the error message above is a bit obscure.

It would be nice if I don't have to launch a VM to run envoy :)

[lizan]

@musaprg can you take a look?

We don't have M1 mac to test for that, but I guess we can use x86_64 binary meanwhile to rely on Rosetta. @fiibbb can you test whether the binary itself works?

[musaprg]

@lizan Sure. Actually, I bought M1 Mac and it will come around 14th Apr. I can work on it after that. cc: @fiibbb

[fiibbb]

Just tried both the getenvoy binary itself and a downloaded envoy binary via getenvoy fetch standard:1.17.1/darwin. Both executes fine on m1 machine (with Rosetta). Looks like it's just a matter of updating homebrew formula and the download script.

[musaprg]

@fiibbb Thank you! I also confirmed that the getenvoy binary itself and fetched envoy binary worked well on M1 Macbook Air with Rosetta. 👍

[musaprg]

Looks like it's just a matter of updating homebrew formula and the download script.

Since fetched envoy will be executed with Rosetta implicitly, it's enough to build just only getenvoy itself for darwin-arm64. But we also need to ensure that it works well on Apple Silicon Mac inside our CI infra. Currently, any cloud provider (including GHA or AWS) doesn't release Apple Silicon instances. After releasing, it's a good time for getenvoy to support Apple Silicon 👍

[codefromthecrypt]

added this issue to ask envoy to retain the binaries they already build envoyproxy/envoy#16830

[codefromthecrypt]

This won't be solved here as this formula is deprecated for the official brew install envoy

Please follow-up on envoyproxy/envoy#16482
and here https://github.com/Homebrew/homebrew-core/blob/master/Formula/envoy.rb