Skip to content

Commit 0bdca7b

Browse files
authored
Merge pull request gemini-testing#706 from leonsabr/force-free-browser
fix: prevent endless loop when suitesPerSession is set to infinity
2 parents 22480d3 + 2b399b6 commit 0bdca7b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/runner/browser-runner/browser-agent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module.exports = class BrowserAgent {
1717
return this._pool.getBrowser(this.browserId)
1818
.then((browser) => {
1919
if (_.includes(this._sessions, browser.sessionId)) {
20-
return this.freeBrowser(browser).then(() => this.getBrowser());
20+
return this.freeBrowser(browser, {force: true}).then(() => this.getBrowser());
2121
}
2222

2323
this._sessions.push(browser.sessionId);

test/unit/runner/browser-runner/browser-agent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('runner/browser-runner/browser-agent', () => {
4848
.then((bro) => {
4949
assert.equal(bro, otherBro);
5050
assert.calledTwice(browserPool.getBrowser);
51-
assert.calledWith(browserPool.freeBrowser, someBro);
51+
assert.calledWith(browserPool.freeBrowser, someBro, {force: true});
5252
});
5353
});
5454

0 commit comments

Comments
 (0)